test(state): Test that Zebra resets correctly when committing blocks fails #5349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-enhancement
teor2345
changed the title
teor2345
changed the base branch from
main
to
non-finalized-block-commit-channel
|
@upbqdn you might want to keep on working on this, I didn't get as far as I thought! |
teor2345
changed the base branch from
non-finalized-block-commit-channel
to
main
teor2345
changed the base branch from
main
to
non-finalized-block-commit-channel
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Automating these tests is out of scope, so I'm going to close this PR now. |
upbqdn
changed the base branch from
non-finalized-block-commit-channel
to
main
…, to improve test coverage (#5164) * Add RPC timing to zcash-rpc-diff * Use transaction hash index for verbose block requests, rather than block data * check if we are at tip for lightwallet wallet tests * move function * Apply suggestions from code review Co-authored-by: teor <teor@riseup.net> * Combine the lightwalletd sync and gRPC test APIs * Rewrite the gRPC and full sync tests for the new APIs * Make zebra_rpc_address optional because only some tests need it * Check for the zebrad RPC port to open in the right place * Do the quick lightwalletd integration tests first in the sequential test function * Ignore the lightwalletd cached state env var in tests that don't want it * Don't replace the state path in RPC tests * Enable IO (and timers) on the tip check tokio runtime * Stop waiting for sync if either waiter thread errors or panics * Try to speed up slow lightwalletd full syncs * Don't wait for the tip in send transaction tests, and try to speed up full lightwalletd syncs * Remove redundant is_lightwalletd_finished store Co-authored-by: Arya <aryasolhi@gmail.com> * Fix unused variable error * Actually create the lightwalletd cached state * Fix lwd cache check logic Co-authored-by: teor <teor@riseup.net> Co-authored-by: Arya <aryasolhi@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…will appear (#5312) * Add latest and edge tags to Docker images * Document how latest tag actually works * Try a different syntax for is_default_branch * Try again * One last try * Revert changes that don't work Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…empool_cancel_mined (#5347)
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 29.0.7 to 32.0.0. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v29.0.7...v32.0.0) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…5368) Bumps [reviewdog/action-actionlint](https://github.com/reviewdog/action-actionlint) from 1.32.0 to 1.33.0. - [Release notes](https://github.com/reviewdog/action-actionlint/releases) - [Commits](reviewdog/action-actionlint@v1.32.0...v1.33.0) --- updated-dependencies: - dependency-name: reviewdog/action-actionlint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to test if the checkpoint verifier, state queues, and block write task are correctly reset on errors.
Closes #2654
Designs
We might want to randomly fail some blocks in some tests, at low probability (1 in 1000 to 1 in 100,000).
We might want to cause errors the first time we reach a height, then validate the block properly the second time.
Solution
Review
This PR is incomplete.
Reviewer Checklist