Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(getblocktemplate): run getblocktemplate-rpcs feature tests in CI #5435

Merged
merged 6 commits into from
Oct 24, 2022

Conversation

oxarbitrage
Copy link
Contributor

@oxarbitrage oxarbitrage commented Oct 20, 2022

Motivation

One option for #5405 is to run a new test task with the getblocktemplate-rpcs feature enabled.

Solution

Run a new task with getblocktemplate-rpc feature enabled. This will run the tests with and without the feature in a separated task for each case. I think is what we want to make sure everything pass when the feature is enabled/disabled in addition to run extra tests when enabled.

New tests can be seen in the logs at:
https://github.com/ZcashFoundation/zebra/actions/runs/3291277916/jobs/5425229470#step:15:4896
https://github.com/ZcashFoundation/zebra/actions/runs/3291277916/jobs/5425229470#step:15:4912

Review

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

Follow Up Work

@oxarbitrage oxarbitrage added the do-not-merge Tells Mergify not to merge this PR label Oct 20, 2022
@github-actions github-actions bot added C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 20, 2022
@oxarbitrage oxarbitrage removed the do-not-merge Tells Mergify not to merge this PR label Oct 20, 2022
@oxarbitrage oxarbitrage marked this pull request as ready for review October 20, 2022 13:12
@oxarbitrage oxarbitrage requested a review from a team as a code owner October 20, 2022 13:12
@oxarbitrage oxarbitrage requested review from teor2345 and removed request for a team October 20, 2022 13:12
@oxarbitrage oxarbitrage marked this pull request as draft October 20, 2022 16:23
@oxarbitrage oxarbitrage marked this pull request as ready for review October 20, 2022 18:19
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you also run the Zebra tests on Docker with this feature?
Docker is our main supported platform, so it needs these tests as well.

- name: Run all zebrad tests

I checked the other workflows:

Lint and build crates individually already run with all features. I don't think we need to run the lightwalletd integration tests, coverage, or parameter downloads with this feature.

@oxarbitrage
Copy link
Contributor Author

@teor2345 teor2345 changed the title ci(getblocktemplate): run tests behind getblocktemplate-rpcs feature in ci ci(getblocktemplate): run getblocktemplate-rpcs feature tests in CI Oct 24, 2022
@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles P-Medium ⚡ C-testing Category: These are tests labels Oct 24, 2022
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I think we might want to run both sets of tests, with and without the new feature. (We can stop doing that when the new feature is on by default.)

@mpguerra mpguerra linked an issue Oct 24, 2022 that may be closed by this pull request
3 tasks
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

mergify bot added a commit that referenced this pull request Oct 24, 2022
@mergify mergify bot merged commit b933f99 into main Oct 24, 2022
@mergify mergify bot deleted the getblocktemplate-ci branch October 24, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-feature Category: New features C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a CI workflow for getblocktemplate-rpcs feature
2 participants