-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(getblocktemplate): run getblocktemplate-rpcs feature tests in CI #5435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, can you also run the Zebra tests on Docker with this feature?
Docker is our main supported platform, so it needs these tests as well.
- name: Run all zebrad tests |
I checked the other workflows:
Lint and build crates individually already run with all features. I don't think we need to run the lightwalletd integration tests, coverage, or parameter downloads with this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I think we might want to run both sets of tests, with and without the new feature. (We can stop doing that when the new feature is on by default.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great!
Motivation
One option for #5405 is to run a new test task with the getblocktemplate-rpcs feature enabled.
Solution
Run a new task with
getblocktemplate-rpc
feature enabled. This will run the tests with and without the feature in a separated task for each case. I think is what we want to make sure everything pass when the feature is enabled/disabled in addition to run extra tests when enabled.New tests can be seen in the logs at:
https://github.com/ZcashFoundation/zebra/actions/runs/3291277916/jobs/5425229470#step:15:4896
https://github.com/ZcashFoundation/zebra/actions/runs/3291277916/jobs/5425229470#step:15:4912
Review
Reviewer Checklist
Follow Up Work