Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(ci): Add patch jobs for lightwalletd build and getblocktemplate-rpcs tests #5474

Merged
merged 3 commits into from
Oct 26, 2022
Merged

change(ci): Add patch jobs for lightwalletd build and getblocktemplate-rpcs tests #5474

merged 3 commits into from
Oct 26, 2022

Conversation

teor2345
Copy link
Contributor

Motivation

We want to add patch jobs so we can require the lightwalletd build and getblocktemplate-rpcs tests to succeed in CI, before merging PRs.

This is a follow-up to PR #5435.
It also closes ticket #4882.

Solution

  • Add the patch jobs
  • Add a missing lightwalletd build concurrency rule

Review

@oxarbitrage created PR #5435, but @gustavovalverde is more familiar with how patch jobs work.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

Follow Up Work

  • After this PR merges, add the two jobs to the branch protection rules (requires admin access)

@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles P-High 🔥 C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 25, 2022
@teor2345 teor2345 self-assigned this Oct 25, 2022
@teor2345 teor2345 requested a review from a team as a code owner October 25, 2022 01:13
@teor2345 teor2345 requested review from gustavovalverde and removed request for a team October 25, 2022 01:13
@github-actions github-actions bot added C-enhancement Category: This is an improvement C-feature Category: New features labels Oct 25, 2022
@mpguerra mpguerra linked an issue Oct 26, 2022 that may be closed by this pull request
Add zcash-lightwalletd / Build images to required jobs #4882
Closed
2 tasks
gustavovalverde
gustavovalverde approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mergify bot added a commit that referenced this pull request Oct 26, 2022
@mergify
Merge of #5474
e0bc0fe
@mergify mergify bot mentioned this pull request Oct 26, 2022
Closed
@mergify mergify bot merged commit 5a6c840 into main Oct 26, 2022
@mergify mergify bot deleted the ci-patch-jobs branch October 26, 2022 22:19
@teor2345 teor2345 mentioned this pull request Nov 1, 2022
Merged
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavovalverde gustavovalverde gustavovalverde approved these changes

Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add zcash-lightwalletd / Build images to required jobs
2 participants
@teor2345 @gustavovalverde