Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge-queue: embarking main (035fad5) and [#5733 + #5716] together #5746

Closed
wants to merge 34 commits into from
Closed

merge-queue: embarking main (035fad5) and [#5733 + #5716] together #5746

wants to merge 34 commits into from

Commits on Nov 24, 2022

  1. updates comments

    @arya2
    arya2 committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    5011db0 View commit details
    Browse the repository at this point in the history

  2. adds check nullifier no dup fns for transactions

    @arya2
    arya2 committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    430ed61 View commit details
    Browse the repository at this point in the history

  3. Adds: 

    - check::anchors fn for tx iter
- TODO comments for unifying nullifiers and anchors checks
- new state request

Updates unknown anchor errors to accomodate tx-only check

Calls new state fn from transaction verifier
    @arya2
    arya2 committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    0789aec View commit details
    Browse the repository at this point in the history

  4. updates check::anchors fns to use transactions 

    updates TransactionContextualValidity request to check sprout anchors

adds comment mentioning TransactionContextualValidity ignores UTXOs
    @arya2
    arya2 committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    72acc4d View commit details
    Browse the repository at this point in the history

  5. conditions new state req call on is_mempool 

    updates tests
    @arya2
    arya2 committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    ad30194 View commit details
    Browse the repository at this point in the history

  6. fix doc link / lint error

    @arya2
    arya2 committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    616e826 View commit details
    Browse the repository at this point in the history

  7. checks for duplicate nullifiers with closures

    @arya2
    arya2 committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    1b12334 View commit details
    Browse the repository at this point in the history

  8. Update zebra-state/src/service/check/nullifier.rs 

    Co-authored-by: teor <teor@riseup.net>
    @arya2 @teor2345
    arya2 and teor2345 committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    6295a8e View commit details
    Browse the repository at this point in the history

  9. documents find_duplicate_nullifier params 

    moves if let statement into for loop
    @arya2
    arya2 committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    4cad214 View commit details
    Browse the repository at this point in the history

  10. renames new state req/res

    @arya2
    arya2 committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    2e48738 View commit details
    Browse the repository at this point in the history

  11. asserts correct response variant in tx verifier

    @arya2
    arya2 committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    03eba19 View commit details
    Browse the repository at this point in the history

  12. adds CheckBestChainTipShieldedSpends call in tx verifier to async checks

    @arya2
    arya2 committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    be723fe View commit details
    Browse the repository at this point in the history

  13. re-adds tracing instrumentation to check::anchors fn 

    renames transaction_in_state to transaction_in_chain
    @arya2
    arya2 committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    65f39ba View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. adds block/tx wrapper fns for anchors checks

    @arya2
    arya2 committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    00c2a4b View commit details
    Browse the repository at this point in the history

  2. uses UnminedTx instead of transaction.hash() 

    deletes broken test
    @arya2
    arya2 committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    55232d1 View commit details
    Browse the repository at this point in the history

  3. updates new state req/res name

    @arya2
    arya2 committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    3f5efe3 View commit details
    Browse the repository at this point in the history

  4. updates tests and uses par_iter for anchors checks

    @arya2
    arya2 committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    c02a5bf View commit details
    Browse the repository at this point in the history

  5. Updates check::anchors pub fn docs.

    @arya2
    arya2 committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    5e1f103 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2022

  1. Adds: 

    - comments / docs
- a TransactionError variant for ValidateContextError
    @arya2
    arya2 committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    115cd6a View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Apply suggestions from code review 

    Co-authored-by: teor <teor@riseup.net>
    @arya2 @teor2345
    arya2 and teor2345 authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    c5c88a0 View commit details
    Browse the repository at this point in the history

  2. moves downcast to From impl 

    rustfmt
    @arya2
    arya2 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    42352a5 View commit details
    Browse the repository at this point in the history

  3. moves the ValidateContextError into an Arc 

    updates comments and naming
    @arya2
    arya2 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    5a064c0 View commit details
    Browse the repository at this point in the history

  4. leaves par_iter for another PR

    @arya2
    arya2 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    84aa68f View commit details
    Browse the repository at this point in the history

  5. Log zebrad config path as well as config values

    @teor2345
    teor2345 authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    11bd49c View commit details
    Browse the repository at this point in the history

  6. Remove duplicate config log

    @teor2345
    teor2345 authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    295e169 View commit details
    Browse the repository at this point in the history

  7. Only log config path and data for server commands

    @teor2345
    teor2345 authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    d095e90 View commit details
    Browse the repository at this point in the history

  8. Use config ref instead

    @teor2345
    teor2345 authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    5329498 View commit details
    Browse the repository at this point in the history

  9. puts io::Error in an Arc

    @arya2
    arya2 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    6796fa1 View commit details
    Browse the repository at this point in the history

  10. updates anchors tests to call tx_anchors check

    @arya2
    arya2 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    1b0d532 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. updates tests to call tx_no_duplicates_in_chain 

    slightly improves formatting
    @arya2
    arya2 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    513b811 View commit details
    Browse the repository at this point in the history

  2. Update zebra-consensus/src/error.rs 

    Co-authored-by: teor <teor@riseup.net>
    @arya2 @teor2345
    arya2 and teor2345 authored Nov 29, 2022
    Configuration menu
    Copy the full SHA
    827ac57 View commit details
    Browse the repository at this point in the history

  3. moves Arc from HistoryError to ValidateContextError

    @arya2
    arya2 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    a01ab07 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Merge of #5733

    @mergify
    mergify[bot] authored Nov 30, 2022
    Configuration menu
    Copy the full SHA
    5b91ec4 View commit details
    Browse the repository at this point in the history

  2. Merge of #5716

    @mergify
    mergify[bot] authored Nov 30, 2022
    Configuration menu
    Copy the full SHA
    396fbc6 View commit details
    Browse the repository at this point in the history