Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(scan): Implement RegisterKeys service request to register new keys #8251

Merged
merged 11 commits into from
Feb 9, 2024
Merged

add(scan): Implement RegisterKeys service request to register new keys #8251

merged 11 commits into from
Feb 9, 2024

Commits on Feb 8, 2024

  1. Refactor obtaining of activation heights

    @upbqdn
    upbqdn committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    c7a7e61 View commit details
    Browse the repository at this point in the history

  2. Impl the RegisterKeys service request

    @upbqdn
    upbqdn committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    c4a7246 View commit details
    Browse the repository at this point in the history

  3. Mock viewing keys for tests

    @upbqdn
    upbqdn committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    8ed93dd View commit details
    Browse the repository at this point in the history

  4. Refactor tests

    @upbqdn
    upbqdn committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    9eb1cab View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:ZcashFoundation/zebra

    @upbqdn
    upbqdn committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    5ebc175 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Merge branch 'main' into impl-key-registration-service

    @upbqdn
    upbqdn committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    d8554c4 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Arya <aryasolhi@gmail.com>
    @upbqdn @arya2
    upbqdn and arya2 authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    f1ef371 View commit details
    Browse the repository at this point in the history

  3. Remove a redundant comment 

    I don't think we need to assume the genesis block doesn't contain
shielded data as the comment says.
    @upbqdn
    upbqdn committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    fda282b View commit details
    Browse the repository at this point in the history

  4. Avoid using a single-letter variable

    @upbqdn
    upbqdn committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    5118f76 View commit details
    Browse the repository at this point in the history

  5. Refactor mocking Sapling scanning keys

    @upbqdn
    upbqdn committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    e634f19 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into impl-key-registration-service

    @upbqdn
    upbqdn committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    8afa7e5 View commit details
    Browse the repository at this point in the history