Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(scan): Implement RegisterKeys service request to register new keys #8251

Merged
merged 11 commits into from
Feb 9, 2024
Merged

add(scan): Implement RegisterKeys service request to register new keys #8251

merged 11 commits into from
Feb 9, 2024

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Feb 8, 2024

Motivation

Close #8203.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Solution

Review

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@upbqdn upbqdn added A-blockchain-scanner Area: Blockchain scanner of shielded transactions P-Medium ⚡ labels Feb 8, 2024
@upbqdn upbqdn self-assigned this Feb 8, 2024
@upbqdn upbqdn requested review from a team as code owners February 8, 2024 22:48
@upbqdn upbqdn requested review from arya2 and removed request for a team February 8, 2024 22:48
@upbqdn
Copy link
Member Author

upbqdn commented Feb 8, 2024

rustfmt reported formatting errors in files this PR doesn't touch. Should be fixed in #8252.

arya2
arya2 previously approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent! Thank you!

All of my suggestions are optional, this PR looks great as-is.

zebra-chain/src/parameters/network.rs Outdated Show resolved Hide resolved
zebra-scan/src/service/scan_task/tests/vectors.rs Outdated Show resolved Hide resolved
zebra-scan/src/tests/vectors.rs Outdated Show resolved Hide resolved
zebrad/tests/common/shielded_scan/scans_for_new_key.rs Outdated Show resolved Hide resolved
zebrad/tests/common/shielded_scan/scans_for_new_key.rs Show resolved Hide resolved
upbqdn and others added 5 commits February 9, 2024 12:28
@upbqdn @arya2
Apply suggestions from code review
f1ef371 
Co-authored-by: Arya <aryasolhi@gmail.com>
@upbqdn
Remove a redundant comment
fda282b 
I don't think we need to assume the genesis block doesn't contain
shielded data as the comment says.
@upbqdn
Avoid using a single-letter variable
5118f76
@upbqdn
Refactor mocking Sapling scanning keys
e634f19
@upbqdn
Merge branch 'main' into impl-key-registration-service
8afa7e5
@upbqdn
Copy link
Member Author

upbqdn commented Feb 9, 2024

I added two more changes that merit review:

@mergify mergify bot merged commit 6b8cbf9 into main Feb 9, 2024
132 checks passed
@mergify mergify bot deleted the impl-key-registration-service branch February 9, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

Assignees

@upbqdn upbqdn

Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions P-Medium ⚡
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement RegisterKeys scan service request to register new keys
2 participants
@upbqdn @arya2