Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting in proptest macros #8252

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Fix formatting in proptest macros #8252

merged 1 commit into from
Feb 9, 2024

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Feb 8, 2024

Motivation

It looks like rustfmt started checking the contents of proptest macros: https://github.com/ZcashFoundation/zebra/actions/runs/7836983037/job/21385757962?pr=8251#step:6:15. Note that the PR didn't edit the files where the reported errors occur.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?

Complex Code or Requirements

Solution

  • Fix the formatting of the affected files.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@upbqdn upbqdn added A-devops Area: Pipelines, CI/CD and Dockerfiles P-High 🔥 labels Feb 8, 2024
@upbqdn upbqdn self-assigned this Feb 8, 2024
@upbqdn upbqdn requested a review from a team as a code owner February 8, 2024 23:38
@upbqdn upbqdn requested review from oxarbitrage and removed request for a team February 8, 2024 23:38
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Feb 8, 2024
@upbqdn upbqdn force-pushed the fix-proptest-formatting branch from 17f960d to 7c4ed30 Compare February 8, 2024 23:42
@upbqdn upbqdn changed the title fix(chain): Fix formatting in proptest macros Fix formatting in proptest macros Feb 8, 2024
@upbqdn
Copy link
Member Author

upbqdn commented Feb 8, 2024

It's not clear to me why this started happening only now, and I also didn't find any relevant updates in rustfmts changelog: https://github.com/rust-lang/rustfmt/blob/master/CHANGELOG.md.

Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@arya2
Copy link
Contributor

arya2 commented Feb 9, 2024

It's not clear to me why this started happening only now, and I also didn't find any relevant updates in rustfmts changelog: https://github.com/rust-lang/rustfmt/blob/master/CHANGELOG.md.

I didn't find anything either, it may have been a bug fix in a transitive dependency.

@mergify mergify bot merged commit 130c4e9 into main Feb 9, 2024
132 checks passed
@mergify mergify bot deleted the fix-proptest-formatting branch February 9, 2024 01:54
@upbqdn upbqdn mentioned this pull request Feb 23, 2024
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-High 🔥
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants