Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(grpc): Unit tests #8293

Merged
merged 6 commits into from
Feb 20, 2024
Merged

tests(grpc): Unit tests #8293

merged 6 commits into from
Feb 20, 2024

Conversation

oxarbitrage
Copy link
Contributor

Motivation

We want to add unit tests to the grpc methods.

Close #8244

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Solution

  • Add unit tests
  • Add guards to method input where needed.

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@oxarbitrage oxarbitrage added C-testing Category: These are tests A-blockchain-scanner Area: Blockchain scanner of shielded transactions P-Medium ⚡ labels Feb 20, 2024
@oxarbitrage oxarbitrage requested a review from a team as a code owner February 20, 2024 14:21
@oxarbitrage oxarbitrage requested review from arya2 and removed request for a team February 20, 2024 14:21
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Feb 20, 2024
@oxarbitrage oxarbitrage mentioned this pull request Feb 20, 2024
Closed
@arya2 arya2 mentioned this pull request Feb 20, 2024
Merged
arya2
arya2 reviewed Feb 20, 2024
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I opened a suggestion PR (#8296) with some cleanups and to run the tests in sequence.

arya2
arya2 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mergify mergify bot merged commit 2f0b284 into main Feb 20, 2024
132 checks passed
@mergify mergify bot deleted the grpc-unit-tests branch February 20, 2024 22:45
idky137 pushed a commit to idky137/zebra that referenced this pull request Feb 28, 2024
@oxarbitrage @arya2 @idky137
tests(grpc): Unit tests (ZcashFoundation#8293)
b16aad3 
* add grpc method unit tests

* add test module description

* runs tests in sequence, adds some messages to assertions, and minor cleanups (ZcashFoundation#8296)

* fix field name change

---------

Co-authored-by: Arya <aryasolhi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

Assignees
No one assigned
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Medium ⚡
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for gRPC methods
2 participants
@oxarbitrage @arya2