Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for 'tests(grpc): Unit tests' #8296

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Feb 20, 2024

Motivation

This is a suggestion PR for #8293 that runs the tests in sequence and has some minor cleanups.

Review

This PR is a suggestion for @oxarbitrage on #8293.

Feel free to merge or close this PR.

@arya2 arya2 requested a review from oxarbitrage February 20, 2024 19:36
@arya2 arya2 self-assigned this Feb 20, 2024
@arya2 arya2 requested a review from a team as a code owner February 20, 2024 19:36
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Feb 20, 2024
@arya2 arya2 mentioned this pull request Feb 20, 2024
7 tasks
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@oxarbitrage oxarbitrage merged commit 377a734 into grpc-unit-tests Feb 20, 2024
123 checks passed
@oxarbitrage oxarbitrage deleted the grpc-tests-suggestion branch February 20, 2024 20:10
mergify bot pushed a commit that referenced this pull request Feb 20, 2024
* add grpc method unit tests

* add test module description

* runs tests in sequence, adds some messages to assertions, and minor cleanups (#8296)

* fix field name change

---------

Co-authored-by: Arya <aryasolhi@gmail.com>
@mpguerra mpguerra linked an issue Feb 21, 2024 that may be closed by this pull request
idky137 pushed a commit to idky137/zebra that referenced this pull request Feb 28, 2024
* add grpc method unit tests

* add test module description

* runs tests in sequence, adds some messages to assertions, and minor cleanups (ZcashFoundation#8296)

* fix field name change

---------

Co-authored-by: Arya <aryasolhi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for gRPC methods
2 participants