-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add(network): Adds a network magic field to testnet::Parameters
and the config
#8524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low the difficulty threshold
…the difficulty threshold is invalid
arya2
added
A-network
Area: Network protocol updates or fixes
NU-6
Network Upgrade: NU6 specific tasks
C-testing
Category: These are tests
P-Medium ⚡
labels
May 14, 2024
github-actions
bot
added
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
May 14, 2024
arya2
commented
May 14, 2024
Merged
9 tasks
oxarbitrage
reviewed
May 15, 2024
…est network magic from zcashd
arya2
force-pushed
the
params-network-magic
branch
from
May 17, 2024 19:38
80a9d26
to
f2bef3a
Compare
oxarbitrage
approved these changes
May 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
5 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-network
Area: Network protocol updates or fixes
C-testing
Category: These are tests
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
NU-6
Network Upgrade: NU6 specific tasks
P-Medium ⚡
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to allow for configuring the network magic on custom testnets.
Part of #7845.
Depends-On: #8518.
PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
Magic
type from zebra-network to zebra-chainnetwork_magic
field ontestnet::Parameters
and uses it in the network codecTesting
Magic
debug impl testWe could also add a test for the constraints in
testnet::ParametersBuilder::with_network_magic()
(can't be the network magic of a default network) if we want.Review
Anyone can review.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work
Accept peer IPs in the config as initial peers.