change(network): Allow custom testnets to make peer connections and configure more parameters #8528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to support configuring more custom testnet parameters and to allow Zebra to make peer connections on custom testnets.
Depends-On: #8524
PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
is_default_testnet()
ininitial_peer_hostnames()
with!is_regtest()
testnet::Parameters
to config deserializationRelated changes:
initial_peers()
whennetwork.is_regtest()
(Zebra shouldn't ever add any peers to the peer cache on Regtest, because it has no initial peers, but it the file could be edited outside Zebra)Testing
Updated the latest stored test config
Review
Anyone can review.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.