refactor: PR review #1100

ZhongAnTech · May 10, 2023 · d04f422 · d04f422
1 parent a4e408a
commit d04f422
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/packages/zarm/src/date-picker/demo.md b/packages/zarm/src/date-picker/demo.md
@@ -270,8 +270,9 @@ const Demo = () => {
       >
         <DateSelect
           value={value}
-          onChange={(value, items) => {console.log('DateSelect onChange', value, items); setValue(value);}}
+          onChange={(value, items) => {console.log('DateSelect onChange', value, items);}}
           onConfirm={(value, items) => {
+            setValue(value);
             Toast.show(value.toLocaleString());
             console.log('DateSelect onConfirm', value, items);
           }}

diff --git a/packages/zarm/src/date-select/DateSelect.tsx b/packages/zarm/src/date-select/DateSelect.tsx
@@ -37,7 +37,6 @@ const DateSelect: React.FC<DateSelectProps> = (props) => {
     filter,
     renderLabel,
     displayRender = (items) => items?.map((item) => item && item.label),
-    onChange,
     onCancel,
     onConfirm,
     ...rest
@@ -67,7 +66,6 @@ const DateSelect: React.FC<DateSelectProps> = (props) => {
     });
 
     onConfirm?.(changedValue, changedItems);
-    onChange?.(changedValue, changedItems);
   };
 
   const handleCancel = () => {

diff --git a/packages/zarm/src/date-select/interface.ts b/packages/zarm/src/date-select/interface.ts
@@ -5,5 +5,4 @@ export interface BaseDateSelectProps extends Omit<BaseDatePickerProps, 'visible'
   placeholder?: string;
   hasArrow?: boolean;
   displayRender?: (items: PickerColumnItem[]) => React.ReactNode;
-  onChange?: (value: Date, items: PickerColumnItem[]) => void;
 }