Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DatePicker cannot be cleared by set undefined #1100

Merged
merged 3 commits into from
May 13, 2023
Merged

fix: DatePicker cannot be cleared by set undefined #1100

merged 3 commits into from
May 13, 2023

Conversation

aiyogg
Copy link
Contributor

@aiyogg aiyogg commented May 5, 2023 •
edited
Loading

fix issuse #1084

@vercel
Copy link

vercel bot commented May 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zarm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 6:28am

@github-actions
Copy link

github-actions bot commented May 5, 2023 •
edited
Loading

🎊 PR Preview has been successfully built and deployed to https://zarm-preview-pr-1100.surge.sh

@aiyogg aiyogg changed the title fix: DatePicker cannot be cleared by set undefined #1084 fix: DatePicker cannot be cleared by set undefined May 5, 2023
@vercel vercel bot temporarily deployed to Preview – zarm May 5, 2023 07:18 Inactive
@JeromeLin JeromeLin requested a review from dominicleo May 5, 2023 07:19
@codecov
Copy link

codecov bot commented May 5, 2023 •
edited
Loading

Codecov Report

Merging #1100 (d04f422) into master (bca9734) will increase coverage by 0.00%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1100   +/-   ##
======================================
  Coverage    2.00%   2.01%           
======================================
  Files         238     238           
  Lines        5325    5323    -2     
  Branches     1256    1212   -44     
======================================
  Hits          107     107           
- Misses       5205    5215   +10     
+ Partials       13       1   -12
Impacted Files Coverage Δ
...kages/zarm/src/date-picker-view/DatePickerView.tsx 0.00% <ø> (ø)
packages/zarm/src/date-select/DateSelect.tsx 0.00% <ø> (ø)

... and 12 files with indirect coverage changes

@vercel vercel bot temporarily deployed to Preview – zarm May 10, 2023 06:28 Inactive
@aiyogg aiyogg requested a review from dominicleo May 10, 2023 06:35
@dominicleo dominicleo merged commit 99cf670 into ZhongAnTech:master May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominicleo dominicleo Awaiting requested review from dominicleo

Assignees
No one assigned
Labels
PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aiyogg @dominicleo