Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Compiled bugs from beta async #157

Open
23 of 29 tasks
MatthewMarinets opened this issue Feb 3, 2024 · 34 comments
Open
23 of 29 tasks

Bug: Compiled bugs from beta async #157

MatthewMarinets opened this issue Feb 3, 2024 · 34 comments

Comments

@MatthewMarinets
Copy link

MatthewMarinets commented Feb 3, 2024

What happened?

Pro tip: start a line with - [ ] and it will turn into an empty checkbox (- [x] for a checked checkbox)

  • Amon's Reach A spore crawler on the first high-ground doesn't move / burrow (--Phanerus)
  • Liberation Day Killing the transport with solar lance doesn't give the check (--ProfBytes)
  • General Raid Liberators / Midnight Riders don't share their siege / unsiege hotkey with vanilla liberators and don't appear in the hotkeys menu; thus unsiege cannot be rebound (--Phanerus)
  • General/Ghost of a Chance Dominated Ravens don't get selected together with player ravens when control-clicking (--KaitoKid)
    • It's fair to keep them in a separate subgroup as they can have different abilities; however, they should probably have the same leader alias / be selected together when selecting by unit type. Mercs, burrowed units, and landed/flying vikings exhibit this behaviour
  • The Outlaws Close Resource check region is far too large (--Alice Voltaire)
  • The Outlaws Close Resource check doesn't trigger (--ProfBytes)
  • Piercing the Shroud Freeing the brutalisk doesn't update the doodad, and it can be spawned again (--Phanerus, --Sheen)
  • Piercing the Shroud The "find warbots" objectives don't get checked off in the second part (--Phanerus, --genderdruid)
  • General Disruptors cost 150/300 instead of 150/150 (--Phanerus)
    • Fix in the works as #93
  • Enemy Intelligence Trying to place a goliath in the south garrison, it got stuck and didn't go in the building (--Berserker)
  • Piercing the Shroud Crash when using solar lance during the escape (--Sheen)
  • General Dark Archon upgrades don't have a parent_item (--Phanerus)
  • Rendezvous Kerrigan does not respawn after dying, after using SOA a lot (--Madi)
  • General AI behaviour dodging disruptor shots is too stupid; 4 disruptors can zone almost as well as 1 liberator pre-patch (--Phanerus)
  • General Disruptor and unburrowed Swarm Host AI target priority seems way too high. Unburrowed Swarm Hosts should not be higher priority than burrowed (--Phanerus)
  • General Disruptors don't require a Robotics Bay when they should (--Phanerus)
  • With Friends Like These Hyperion's command-card priority is lower than some units e.g. Valkyries (--Magnemania)
  • Echoes of the Future the Zerg Wave countdown timer is hidden behind the Archipelago message box (--Phanerus)
  • General Kerrigan is not in the Archipelago Zerg hotkey category (--Phanerus)
  • Spear of Adun Probes don't automatically start mining at the start of the mission (--Phanerus, --Salzkorn)
  • In the Enemy's Shadow loading screen background image doesn't fill the screen. I think there's an option in the MapInfo / Background screen option whether it stretches, fills, or fits -- should be fill. (--Phanerus)
  • General Infested Siege Tanks and Infested Banshees are not biological (and they should probably be using the stukov models / icons) (--Phanerus)
    • For siege tanks, it's a known issue that there's no working jump jets animation for the infested siege tank model. I reiterate that we can just replace it with the stukov deep tunnel ability as functionally the same role (and lacking another way to get it)
  • Old Soldiers Extra Starting Supply not sending / remaining properly after nukes (--Phanerus)
  • Templar's Charge The timer for Alarak to open the vault door is hidden behind the AP message window (--Phanerus)
  • Liberation Day Raynor doesn't have a dummy stim in the command card to stim marines if you have it (--Phanerus)
  • General Zerg morphing mutalisks into vipers doesn't play an "enter cocoon" animation before turning into the cocoon (--Phanerus)
  • In Utter Darkness Winning before Artanis appears does not give the "In Utter Darkness: Artanis" Extra check. (--Phanerus)
  • General Protoss Corsair Disruption Web can't target an area, only a unit (--Phanerus)
  • General Zerg Twin Drones don't use the twin drones / zagara skin Ignore, we have other ideas that would use other drone skins

What were the expected results?

Fixes

Software

While playing

@Salzkorn
Copy link

Salzkorn commented Feb 3, 2024

Adding onto this:
On Fire in the Sky, I got the North Zerg Rescue as I approached it, rather than after rescuing the units.

@Ziktofel
Copy link
Owner

Ziktofel commented Feb 3, 2024

you can obtain Dark Archons in two ways: Dark Archon item or DT + Dark Archon Meld

@Magnemania
Copy link

Adding onto this: On Fire in the Sky, I got the North Zerg Rescue as I approached it, rather than after rescuing the units.

Also received Close Zerg Rescue as I approached it, rather than after rescuing the units.

@Magnemania
Copy link

Magnemania commented Feb 3, 2024

The new locations on Harvest of Screams are listed as Vanilla rather than Extra. None of these new locations provided metaprogression in the original campaign and the vanilla Ursadon locations already hit the target of 3 locations.

image

@MatthewMarinets MatthewMarinets changed the title Bug: Compiled bugs from day 1 of async Bug: Compiled bugs from beta async Feb 3, 2024
@Magnemania
Copy link

image

Hyperion (With Friends Like These) should probably be given a really high selection priority.

@AliceVoltaire
Copy link

AliceVoltaire commented Feb 4, 2024

My Day 2 bug reports:

  • On both Sky Shield and Amon's Reach, the Spear of Adun Orbital Strike cutscene (about a minute into each mission) does not have the Orbital Strike lasers like its supposed to. The enemies just kind of explode and its underwhelming.

  • On Sky Shield, the Moebius Corps AI is named "Computer 2" instead of "Moebius Corps".

  • On Sky Shield and Spear of Adun, the worker rally point from the starting Nexus is not set from start.

  • On The Escape, I'm able to Blink into this room, but I cannot walk over to the other side of the room due to an invisible wall. Might be worth removing that wall, as it would open up some interesting Blink flanking strategies.
    image

@Matiya-star
Copy link

Matiya-star commented Feb 4, 2024

Torrasque Ultralisk don't leave a coocon, and instead just leave an unselectable invisible corpse on the ground. Ultralisk never revives.

Mission: Phantoms of the Void
Upgrades: Torrasque Strain Ultralisk, do not have ultralisk unit unlocked.
image

@Salzkorn
Copy link

Salzkorn commented Feb 4, 2024

On Back in the Saddle with Hard difficulty and cutscenes off, there's a bunch of restoration charges that shouldn't be there.
This probably affects Brutal too, and Brutal removes a few more charge stations.
SC2_x64_6GLAVVh4iv
SC2_x64_0B2XQFgXCu
For the below one I accidentally picked it up before taking a screenshot
SC2_x64_529nh2qa8A
SC2_x64_eTklA0Cb1U
SC2_x64_o2q6ZgI4sp

@MatthewMarinets
Copy link
Author

On Sky Shield and Spear of Adun, the worker rally point from the starting Nexus is not set from start.

This is an issue on Forbidden Weapon as well.

@MatthewMarinets
Copy link
Author

On Back in the Saddle with Hard difficulty and cutscenes off, there's a bunch of restoration charges that shouldn't be there. This probably affects Brutal too, and Brutal removes a few more charge stations.

Didn't see this problem on Brutal difficulty with Kerriganless / grant story tech

@MatthewMarinets
Copy link
Author

Interesting one: On Purification, the Purifier attack wave was just weak, and didn't manage to clear the bottom left. Once the last instigator I was aware of died, I just permanently had vision of that area (I'm assuming something went wrong with an actor). I also notice some sentinels in a purifier spawn point I haven't unlocked yet, not sure if they're there in vanilla.
Screenshot2024-02-04 03_53_16
Screenshot2024-02-04 03_54_48

@EnvyDragon
Copy link

EnvyDragon commented Feb 4, 2024

  • General: Dragoons don't have Guardian Shell behaviors. (They die without being shell'd, and I see in the code that the behavior is missing) (EDIT: fixed now)

(spitballing: should we have like, an AP behavior controller unit that applies co-op/mapwide behaviors to all of a player's units and allied units? would save some pain especially if we start adapting some of the weirder co-op stuff)

@MatthewMarinets
Copy link
Author

spitballing: should we have like, an AP behavior controller unit that applies co-op/mapwide behaviors to all of a player's units

My instinct is code generation in the map build script, but I'm a tools developer and metaprogramming / code generation is my favourite solution to everything

@Bicoloursnake
Copy link

Bicoloursnake commented Feb 5, 2024

  • Back in the Saddle:
    On Brutal, the tram engines start with 150 health each, but the global health bar in the top left has them at 200 each, so it starts with 25% health knocked off on the health bar at start.

  • In Utter Darkness:
    The instant die button on In Utter Darkness is available at the beginning of the mission and sends the defeat condition before you get the required number of kills (in vanilla, you cannot clear the mission until you get the prerequisite number of kills).

  • Missions that have Kerrigan and SOA:
    Using one of the SOA 'pause' abilities (Orbital Strike, Temporal Field, Solar Lance, etc.) while Kerrigan is respawning will prevent her from respawning (this was also previously an issue with Nova, but that has been fixed)

  • Amon's fall logic is probably too loose without economy upgrades. Vanilla gives you better Overlords, Twin Drones, and Auto Gas to let you get on the map quickly to prevent Amon from building up too much. Without those upgrades, you need quite a bit of punch to break through.

  • Enemy Intelligence:
    I orbital striked a ghost on to the beacon for the garrison just north of base, and that ghost decided to hang out on the beacon instead of actually joining the garrison (though it did count towards the garrison score)

  • Maw of the Void (potentially Safe Haven too):
    Whatever this is https://www.youtube.com/watch?v=ff8JCZJdd6Q

  • Amon's Reach:
    Overseer and Spore Crawler Detection radii do not correctly appear when DTs are actively selected.

  • A Sinister Turn:
    Avengers do not properly recall to the Dank Shrine just outside the Main Base.

@MatthewMarinets
Copy link
Author

MatthewMarinets commented Feb 5, 2024

  • I couldn't pick up this particular egg on Kerriganless Domination
    Screenshot2024-02-04 22_03_36

@Magnemania
Copy link

Magnemania commented Feb 6, 2024

image
Mind controlling units in The Growing Shadow does not count as killing them for the purpose of this objective.

@EnvyDragon
Copy link

  • Temple of Unification: Titanic Warp Prism doesn't do anything
  • The Infinite Cycle: Colossi/Zealots that warp in from the SW in the first holdout have silly-looking animations (nitpick)

@Salzkorn
Copy link

Salzkorn commented Feb 6, 2024

  • Armored Suit Module (Nova Suit Module) is missing a buff icon on Nova

@Bicoloursnake
Copy link

Bicoloursnake commented Feb 7, 2024

  • Evil Awoken: With 3 tiers of upgrades and auto_on_no_build on, Zeratul only has 3/3/2. All other units have 3/3/3 as expected.

@Salzkorn
Copy link

Salzkorn commented Feb 7, 2024

  • Harvest of Screams: With cutscenes & camera grabs off, after losing two zerglings to the intro Ursadon Matriarch I get 999 respawning zerglings
    SC2_x64_FBDb3j6Wn5

@Magnemania
Copy link

Magnemania commented Feb 7, 2024

  • Protoss Core: High Templar have no attack animation. I believe they are using the WoL assets, which don't have an attack animation (since HTs cannot attack in WoL).

@Bicoloursnake
Copy link

Bicoloursnake commented Feb 7, 2024

  • Harbinger of Oblivion:
    Kerrigan's forces are not protected by Shield Overcharge like they are in Vanilla

  • Brothers in Arms:
    Neither Raynor's nor Valerian's troops are protected by Shield Overcharge (not sure if you can actually have shield over charge by this point in vanilla, so don't have the same point of reference

  • Salvation: Allies didn't receive shielding from shield overcharge.

Ghosts in the Fog: Player's mechanical units and buildings are not repaired by Reconstruction Beam

Misunderstood SOA settings, not a bug

@Bicoloursnake
Copy link

Bicoloursnake commented Feb 7, 2024

  • Infested: Kerrigan has a kill count, not a level count.

Ziktofel added a commit to Ziktofel/Archipelago-SC2-data that referenced this issue Feb 7, 2024
Ziktofel added a commit to Ziktofel/Archipelago-SC2-data that referenced this issue Feb 7, 2024
@Ziktofel
Copy link
Owner

Ziktofel commented Feb 7, 2024

  • Armored Suit Module (Nova Suit Module) is missing a buff icon on Nova

This one has a problem as it's split off Jumpsuit (in vanilla Jump Suit has both the speed, jumping and highest HP/Armor)
You'll notice this if you have higher Nova HP

Ziktofel added a commit to Ziktofel/Archipelago-SC2-data that referenced this issue Feb 7, 2024
@Salzkorn
Copy link

Salzkorn commented Feb 7, 2024

  • Armored Suit Module (Nova Suit Module) is missing a buff icon on Nova

This one has a problem as it's split off Jumpsuit (in vanilla Jump Suit has both the speed, jumping and highest HP/Armor) You'll notice this if you have higher Nova HP

I absolutely did not notice it and was very confused as to why I was regenerating out of combat. If it was just bonus stats it would be one thing, but the regeneration really needs to be explained somewhere.

Ziktofel added a commit to Ziktofel/Archipelago-SC2-data that referenced this issue Feb 7, 2024
Ziktofel added a commit to Ziktofel/Archipelago-SC2-data that referenced this issue Feb 7, 2024
Ziktofel added a commit to Ziktofel/Archipelago-SC2-data that referenced this issue Feb 7, 2024
Ziktofel added a commit to Ziktofel/Archipelago-SC2-data that referenced this issue Feb 7, 2024
Ziktofel added a commit to Ziktofel/Archipelago-SC2-data that referenced this issue Feb 7, 2024
Ziktofel added a commit to Ziktofel/Archipelago-SC2-data that referenced this issue Feb 7, 2024
@Ziktofel
Copy link
Owner

Ziktofel commented Feb 7, 2024

@Bicoloursnake Shall we remove Kerrigan Presence option option_not_present_and_no_passives or fail to generate if Epilogue is present? (Amon's Fall)

(or another solution)

@Ziktofel
Copy link
Owner

Ziktofel commented Feb 7, 2024

@MatthewMarinets Ain't this:

Piercing the Shroud Freeing the brutalisk doesn't update the doodad, and it can be spawned again (--Phanerus, --Sheen)

tied to Cutscene skip option?

@MatthewMarinets
Copy link
Author

MatthewMarinets commented Feb 7, 2024

@MatthewMarinets Ain't this:

Piercing the Shroud Freeing the brutalisk doesn't update the doodad, and it can be spawned again (--Phanerus, --Sheen)

tied to Cutscene skip option?

Yep, I had skip cutscenes and no_force_camera turned on. I can't speak for Sheen but I expect the same for him. Being able to respawn the brutalisk was information from Sheen, I didn't confirm it.

@AliceVoltaire
Copy link

AliceVoltaire commented Feb 8, 2024

second round of compiled bugs:

  • Brothers in Arms, Trouble in Paradise do not have worker rally set on start.

  • On Flashpoint, Nova does not drop a nuke in the opening cutscene.

  • When selecting Nova without Superstim, with a unit that has regular Stim, it shows Nova as having Superstim.
    image

  • On Templar's Return, the Protect Alarak timer is covered by the AP message box.
    image

  • On Enemy Intelligence, if you let the opening cutscene play out, the Factory and Barracks do not start in their correct spots.
    Unskipped:
    image
    Skipped:
    image

@MatthewMarinets
Copy link
Author

When selecting Nova without Superstim, with a unit that has regular Stim, it shows Nova as having Superstim.

This is filed separately under #163 to give some more details on expected behaviour / implementation ideas.

@Ziktofel
Copy link
Owner

Ziktofel commented Feb 8, 2024

@AliceVoltaire Did you update the data? As Templar's Return was fixed in Ziktofel/Archipelago-SC2-data@230d0ca

Ziktofel added a commit to Ziktofel/Archipelago-SC2-data that referenced this issue Feb 8, 2024
@Bicoloursnake
Copy link

@Bicoloursnake Shall we remove Kerrigan Presence option option_not_present_and_no_passives or fail to generate if Epilogue is present? (Amon's Fall)

(or another solution)

I think it would make sense to force passives on for Amon's Fall with a warning message. I think it also makes sense to require either Twin Drones or Automated Extractor for standard tactics (with the acknowledgement that they would need to be made progression items). It's certainly possible without either of these, but it's rough enough (even with broodlords or ultras) that it probably should be restricted to advanced tactics.

@Bicoloursnake
Copy link

Bicoloursnake commented Feb 10, 2024

  • Protoss General: High Archon and High Templar do not have the same selection priority (for example, Annihilators appear between them when all three are selected).

@Ziktofel
Copy link
Owner

  • Protoss General: High Archon and High Templar do not have the same selection priority (for example, Annihilators appear between them when all three are selected).

Upgrades don't shuffle the orders for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants