Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document _origin. #129

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Document _origin. #129

merged 2 commits into from
Dec 16, 2020
+14 −5

Conversation

vaivaswatha
Copy link
Contributor

Reference: Zilliqa/scilla#921

jjcnn
jjcnn approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@jjcnn jjcnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few suggestions for changes, but they're not essential, so use them at your discretion.

@vaivaswatha @jjcnn
Apply suggestions from code review
a721958 
Co-authored-by: jjcnn <38888011+jjcnn@users.noreply.github.com>
@vaivaswatha vaivaswatha merged commit 1cde3cf into master Dec 16, 2020
@vaivaswatha vaivaswatha deleted the doc_origin branch December 16, 2020 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjcnn jjcnn jjcnn approved these changes

@renlulu renlulu Awaiting requested review from renlulu

@anton-trunov anton-trunov Awaiting requested review from anton-trunov

@AmritKumar AmritKumar Awaiting requested review from AmritKumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaivaswatha @jjcnn