Add support for _origin implicit transition parameter
#921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaivaswatha
requested review from
anton-trunov,
AmritKumar,
micovi,
renlulu,
kaikawaliu and
jjcnn
You're right. I'm now adding a test for this. |
anton-trunov
approved these changes
Dec 15, 2020
jjcnn
approved these changes
Dec 15, 2020
renlulu
approved these changes
Dec 16, 2020
vaivaswatha
added a commit
to Zilliqa/scilla-docs
that referenced
this pull request
Dec 16, 2020
Reference: Zilliqa/scilla#921
kaikawaliu
approved these changes
Dec 16, 2020
vaivaswatha
added a commit
to Zilliqa/scilla-docs
that referenced
this pull request
Dec 16, 2020
* Document _origin. Reference: Zilliqa/scilla#921 * Apply suggestions from code review Co-authored-by: jjcnn <38888011+jjcnn@users.noreply.github.com> Co-authored-by: jjcnn <38888011+jjcnn@users.noreply.github.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
_sender, all transitions now have an implicit paramter_origin, to denote the source of a transaction. The blockchain now needs to supply this value similar to how it supplies_sender. JSON interactions (such as in the IDE) will need to to be updated too.