Improve UserValidator default behavior [4.0 beta]

[gabrielalmeida]

UserValidator present design doesn't provide good UX practices and easy client-side validation via
$user->errors.

It overwrites $user->errors each time UserValidator->attachErrorMsg() method runs, providing only 'one' error at time instead of all of them, making user progress at completing unvalidated fields slower and unintelligent.

It also doesn't follow MessageBag default behavior, which is a key corresponding to input names/model attributes and its respective value. It actually adds a MessageBag with confide key, so client-side validation by matching keys from $user->errors isn't possible..

Note that UserValidator->ValidateIsUnique() method is still showing only first error but now at least exports correct error key to $user->errors.

Unity test to UserValidator->attachErrorMsg() must be updated if merged since it was redone to work directly with MessageBag object instead of ConfideUserInterface.

[coveralls]

Coverage decreased (-3.21%) when pulling c5699fe on gabrielalmeida:huge-update into 19f3eb7 on Zizaco:huge-update.

[Zizaco]

@gabrielalmeida Good catch!

My only concern is about changing the first parameter of attachErrorMsg to a MessageBag.

For me it seems better to look for the error attribute inside attachErrorMsg method. I believe it's a better design since the attachErrorMsg is a simpler method and that have the single responsibility of attaching error messages. It can look if the error attribute contains a MessageBag, if so, call merge else create a new one.

About the the $key attribute, I think it's very good. Seems very reasonable to me.

This way you will not have to pass $user->errors everytime, but simply the $user and the only test that you'd have to tweak is UserValidatorTest::testShouldAttachErrorMsg

What do you think about making these changes? You can create another PR if you like.

[GrahamCampbell]

Please indent with spaces. :P

[GrahamCampbell]

The indentation here is wrong. There's a mix of tabs and spaces. There should only be spaces.

[Zizaco]

@GrahamCampbell Yes you're right. I plan to fix then if @gabrielalmeida did not.

[Zizaco]

I did this: 139d44b