Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve default UserValidator behavior[4.0.0 beta 2] #318

Merged
merged 1 commit into from
Jul 20, 2014

Conversation

gabrielalmeida
Copy link
Contributor

Hi, some features not added to #311:

  • Reordered validations – since a validateIsUnique or validatePassword message should not be key overwritten by validateAttributes as this last one is probably a less relevant error message
  • Now all validations are called even if one of them fails.. So all validation messages are sent at once.
  • validateIsUnique method now sends key to attachErrorMsg and also check for errors on each $identity field at once

🍻

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ddb91c4 on gabrielalmeida:huge-update into 07d1bda on Zizaco:huge-update.

@gabrielalmeida gabrielalmeida changed the title Improve default UserValidator behavior[Confide 4.0 beta 2] Improve default UserValidator behavior[4.0.0 beta 2] Jul 20, 2014
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c2ada2b on gabrielalmeida:huge-update into 07d1bda on Zizaco:huge-update.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c2ada2b on gabrielalmeida:huge-update into 07d1bda on Zizaco:huge-update.

@Zizaco
Copy link
Owner

Zizaco commented Jul 20, 2014

@gabrielalmeida Nice contribution! Thanks

Zizaco added a commit that referenced this pull request Jul 20, 2014
Improve default UserValidator behavior[4.0.0 beta 2]
@Zizaco Zizaco merged commit e113fc5 into Zizaco:huge-update Jul 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants