engine:refactor - improving engine code and performance #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanmartinszup
force-pushed
the
refactor
branch
8 times, most recently
from
4a6e0ac to
1dd2cb3
Compare
nathanmartinszup
requested review from
lucasbrunozup and
wiliansilvazup
as code owners
nathanmartinszup
changed the title
nathanmartinszup
force-pushed
the
refactor
branch
from
1dd2cb3 to
37c4036
Compare
iancardosozup
approved these changes
Jan 13, 2022
matheusalcantarazup
suggested changes
Jan 13, 2022
This commit contains a complete engine refactoring and includes some breaking changes. The use of the engine has been simplified to just one function called Run, this function will receive a context, project path that must be analyzed and a slice of rules. These rules are defined by a generic interface and each one have your own implementation, that will make it easy to add other types of analysis in the future, such as semantic. Various performance and code improvements have also been made, which dramatically improved code quality and analysis time. Signed-off-by: Nathan Martins <nathan.martins@zup.com.br>
nathanmartinszup
force-pushed
the
refactor
branch
from
37c4036 to
777c1a9
Compare
matheusalcantarazup
approved these changes
Jan 13, 2022
wiliansilvazup
approved these changes
Jan 17, 2022
ne0z
pushed a commit
to ne0z/horusec-engine
that referenced
this pull request
Jun 23, 2022
This commit contains a complete engine refactoring and includes some breaking changes. The use of the engine has been simplified to just one function called Run, this function will receive a context, project path that must be analyzed and a slice of rules. These rules are defined by a generic interface and each one have your own implementation, that will make it easy to add other types of analysis in the future, such as semantic. Various performance and code improvements have also been made, which dramatically improved code quality and analysis time. Signed-off-by: Nathan Martins <nathan.martins@zup.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains a complete engine refactoring and includes some
breaking changes. The use of the engine has been simplified to just one
function called Run, this function will receive a context, project path
that must be analyzed and a slice of rules. These rules are defined by
a generic interface and each one have your own implementation, that will
make it easy to add other types of analysis in the future, such as semantic.
Various performance and code improvements have also been made, which
dramatically improved code quality and analysis time.
Signed-off-by: Nathan Martins nathan.martins@zup.com.br
- What I did
- How to verify it
- Description for the changelog