engine:chore - update to new engine #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iancardosozup
force-pushed
the
test/new-engine
branch
4 times, most recently
from
8511109 to
4af272f
Compare
|
| Secret | Commit | Filename | Detected At | |
|---|---|---|---|---|
| Generic High Entropy Secret | 94a540a | internal/services/engines/leaks/rules_test.go | 13:06 January 25th, 2022 | View secret |
| Generic High Entropy Secret | 94a540a | internal/services/engines/leaks/rules_test.go | 13:06 January 25th, 2022 | View secret |
| Square Token | 94a540a | internal/services/engines/leaks/rules_test.go | 13:06 January 25th, 2022 | View secret |
| AWS Keys | 94a540a | internal/services/engines/leaks/rules_test.go | 13:06 January 25th, 2022 | View secret |
| Amazon MWS Token | 94a540a | internal/services/engines/leaks/rules_test.go | 13:06 January 25th, 2022 | View secret |
| Stripe Keys | 94a540a | internal/services/engines/leaks/rules_test.go | 13:06 January 25th, 2022 | View secret |
| Stripe Keys | 94a540a | internal/services/engines/leaks/rules_test.go | 13:06 January 25th, 2022 | View secret |
| Generic High Entropy Secret | 94a540a | internal/services/engines/leaks/rules_test.go | 13:06 January 25th, 2022 | View secret |
| Generic High Entropy Secret | 94a540a | internal/services/engines/leaks/rules_test.go | 13:06 January 25th, 2022 | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.
Our GitHub checks need improvements? Share your feedbacks
iancardosozup
force-pushed
the
test/new-engine
branch
from
4af272f to
430fbd5
Compare
iancardosozup
requested review from
lucasbrunozup,
matheusalcantarazup,
nathanmartinszup and
wiliansilvazup
as code owners
matheusalcantarazup
approved these changes
Jan 13, 2022
iancardosozup
force-pushed
the
test/new-engine
branch
from
430fbd5 to
bd8a79a
Compare
matheusalcantarazup
suggested changes
Jan 13, 2022
iancardosozup
force-pushed
the
test/new-engine
branch
2 times, most recently
from
d388dc7 to
de8fcac
Compare
iancardosozup
force-pushed
the
test/new-engine
branch
from
de8fcac to
a0b9d41
Compare
nathanmartinszup
approved these changes
Jan 14, 2022
matheusalcantarazup
approved these changes
Jan 14, 2022
wiliansilvazup
approved these changes
Jan 19, 2022
iancardosozup
force-pushed
the
test/new-engine
branch
3 times, most recently
from
07c8990 to
0996036
Compare
Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
iancardosozup
force-pushed
the
test/new-engine
branch
from
0996036 to
94a540a
Compare
nathanmartinszup
pushed a commit
that referenced
this pull request
Apr 4, 2022
Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br> (cherry picked from commit 3d9f22a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Cardoso ian.cardoso@zup.com.br
depends on engine refactor
- What I did
- How to verify it
- Description for the changelog