Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatters/nancy: log correct errors #814

Closed
wiliansilvazup opened this issue Nov 24, 2021 · 0 comments · Fixed by #906 or #922
Closed

formatters/nancy: log correct errors #814

wiliansilvazup opened this issue Nov 24, 2021 · 0 comments · Fixed by #906 or #922
Labels
kind/bug Something isn't working

Comments

@wiliansilvazup
Copy link
Contributor

What happened:
In PR #806 was create thread about errors returned from nancy tool, they are:
1º Output wrong;
2º Nancy return error with this log in debug mode nancy-output-error.txt but in end of the analysis the error in output is Can'ot possible convert 'C' to struct....

What you expected to happen:
Error about i not using GITHUB_TOKEN environment variable, but the error was other.

How to reproduce it (as minimally and precisely as possible):
Create multiple analysis in go examples folder in order to achieve github's rate-limit. And see this log only show in debug mode.

Anything else we need to know?:
You can use e2e test to validate if nancy is ok with change.

@wiliansilvazup wiliansilvazup added the kind/bug Something isn't working label Nov 24, 2021
@matheusalcantarazup matheusalcantarazup changed the title Nancy tool returning error formatters/nancy: log correct errors Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
1 participant