nancy:chore - Error not handled by Horusec in Nancy tool #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiliansilvazup
requested review from
iancardosozup,
lucasbrunozup,
matheusalcantarazup and
nathanmartinszup
as code owners
wiliansilvazup
changed the title
wiliansilvazup
force-pushed
the
bugfix/nancy-ratelimit
branch
from
124c737 to
709d3a1
Compare
wiliansilvazup
force-pushed
the
bugfix/nancy-ratelimit
branch
5 times, most recently
from
371cb1b to
abf24e2
Compare
**- What I did** The nancy tool requires access to the Github API's, but when accessed several times without an identification it is blocked until the user identifies himself using an authentication token that can be generated via Github, so I created a validation for this scenario and the user can add this environment variable before starting an analysis. **- How to verify it** Run many times GoLang project and see follow error: ```bash Invalid character 'E' looking for beginning of value ``` **- Description for the changelog** Error not handled by Horusec in Nancy tool [#905](#905) Signed-off-by: wilian <wilian.silva@zup.com.br>
wiliansilvazup
force-pushed
the
bugfix/nancy-ratelimit
branch
from
abf24e2 to
2371340
Compare
iancardosozup
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
The nancy tool requires access to the Github API's, but when accessed several times without an identification
it is blocked until the user identifies himself using an authentication token that can be generated via Github,
so I created a validation for this scenario and the user can add this environment variable before starting an analysis.
- How to verify it
Run many times GoLang project and see follow error:
- Description for the changelog
Error not handled by Horusec in Nancy tool #905
Signed-off-by: wilian wilian.silva@zup.com.br