nancy:chore - remove logs when running without GITHUB_TOKEN env #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously for each analysis a warning log was being printed informing an error of Github API rate limit from Nancy. This commit change this behaviour to just log in debug level that Nancy was ignored because the GITHUB_TOKEN env is not set. Fixes #920 Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
wiliansilvazup
approved these changes
Jan 10, 2022
nathanmartinszup
approved these changes
Jan 10, 2022
nathanmartinszup
pushed a commit
that referenced
this pull request
Jan 10, 2022
Previously for each analysis a warning log was being printed informing an error of Github API rate limit from Nancy. This commit change this behaviour to just log in debug level that Nancy was ignored because the GITHUB_TOKEN env is not set. Fixes #920 Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br> (cherry picked from commit d0f5f52)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously for each analysis a warning log was being printed informing
an error of Github API rate limit from Nancy. This commit change this
behaviour to just log in debug level that Nancy was ignored because the
GITHUB_TOKEN env is not set.
Fixes #920
Signed-off-by: Matheus Alcantara matheus.alcantara@zup.com.br
- What I did
- How to verify it
- Description for the changelog