Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BundlerAudit return error in format of the vulnerability #919

Closed
wiliansilvazup opened this issue Jan 10, 2022 · 0 comments · Fixed by #921
Closed

BundlerAudit return error in format of the vulnerability #919

wiliansilvazup opened this issue Jan 10, 2022 · 0 comments · Fixed by #921
Assignees
@matheusalcantarazup
Labels
kind/bug Something isn't working

Comments

@wiliansilvazup
Copy link
Contributor

wiliansilvazup commented Jan 10, 2022 •
edited
Loading

What happened:
in this workflow you can see that only one vulnerability was detected in the project, but in the description it says:

Code: Could not find "Gemfile.lock" in "/src"
Details:  (Could not find "Gemfile.lock" in "/src" - )  ( - )

I believe this problem can only be reported as a warning or error log.

What you expected to happen:
Not report problem in the format of vulnerability

How to reproduce it (as minimally and precisely as possible):
Run Ruby project without Gemfile.lock file

Environment:

  • Horusec version (use horusec version): latest-rc v2.7.0-rc.1
  • Operating System: linux, github-actions
@wiliansilvazup wiliansilvazup added the kind/bug Something isn't working label Jan 10, 2022
matheusalcantarazup added a commit that referenced this issue Jan 10, 2022
@matheusalcantarazup
bundler:fix - correctly parse output error
6b9491e 
Previously when a project path does not have a Gemfile.lock file, the
Bundler return an error `Could not find "Gemfile.lock"` that was being
interpreted as a vulnerability. This was happening because the commit
rubysec/bundler-audit@021f85f change the error
message from a generic error like "Errno::ENOENT" and "No such file or
directory" to a more detailed error `Could not find "Gemfile.lock"`.

Fixes #919

Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
@matheusalcantarazup matheusalcantarazup mentioned this issue Jan 10, 2022
Merged
matheusalcantarazup added a commit that referenced this issue Jan 10, 2022
@matheusalcantarazup
bundler:fix - correctly parse output error
b4457f6 
Previously when a project path does not have a Gemfile.lock file, the
Bundler return an error `Could not find "Gemfile.lock"` that was being
interpreted as a vulnerability. This was happening because the commit
rubysec/bundler-audit@021f85f change the error
message from a generic error like "Errno::ENOENT" and "No such file or
directory" to a more detailed error `Could not find "Gemfile.lock"`.

Fixes #919

Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
matheusalcantarazup added a commit that referenced this issue Jan 10, 2022
@matheusalcantarazup
bundler:fix - correctly parse output error (#921)
9245d7d 
Previously when a project path does not have a Gemfile.lock file, the
Bundler return an error `Could not find "Gemfile.lock"` that was being
interpreted as a vulnerability. This was happening because the commit
rubysec/bundler-audit@021f85f change the error
message from a generic error like "Errno::ENOENT" and "No such file or
directory" to a more detailed error `Could not find "Gemfile.lock"`.

Fixes #919

Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
nathanmartinszup pushed a commit that referenced this issue Jan 10, 2022
@matheusalcantarazup @nathanmartinszup
bundler:fix - correctly parse output error (#921)
2534b54 
Previously when a project path does not have a Gemfile.lock file, the
Bundler return an error `Could not find "Gemfile.lock"` that was being
interpreted as a vulnerability. This was happening because the commit
rubysec/bundler-audit@021f85f change the error
message from a generic error like "Errno::ENOENT" and "No such file or
directory" to a more detailed error `Could not find "Gemfile.lock"`.

Fixes #919

Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
(cherry picked from commit 9245d7d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matheusalcantarazup matheusalcantarazup

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bundler:fix - correctly parse output error ZupIT/horusec
2 participants
@wiliansilvazup @matheusalcantarazup