bundler:fix - correctly parse output error #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
Previously when a project path does not have a Gemfile.lock file, the Bundler return an error `Could not find "Gemfile.lock"` that was being interpreted as a vulnerability. This was happening because the commit rubysec/bundler-audit@021f85f change the error message from a generic error like "Errno::ENOENT" and "No such file or directory" to a more detailed error `Could not find "Gemfile.lock"`. Fixes #919 Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
matheusalcantarazup
force-pushed
the
fix-bundler-output-parser
branch
from
6b9491e to
b4457f6
Compare
wiliansilvazup
approved these changes
Jan 10, 2022
nathanmartinszup
approved these changes
Jan 10, 2022
nathanmartinszup
pushed a commit
that referenced
this pull request
Jan 10, 2022
Previously when a project path does not have a Gemfile.lock file, the Bundler return an error `Could not find "Gemfile.lock"` that was being interpreted as a vulnerability. This was happening because the commit rubysec/bundler-audit@021f85f change the error message from a generic error like "Errno::ENOENT" and "No such file or directory" to a more detailed error `Could not find "Gemfile.lock"`. Fixes #919 Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br> (cherry picked from commit 9245d7d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when a project path does not have a Gemfile.lock file, the
Bundler return an error
Could not find "Gemfile.lock"that was beinginterpreted as a vulnerability. This was happening because the commit
rubysec/bundler-audit@021f85f change the error
message from a generic error like "Errno::ENOENT" and "No such file or
directory" to a more detailed error
Could not find "Gemfile.lock".Fixes #919
Signed-off-by: Matheus Alcantara matheus.alcantara@zup.com.br
- What I did
- How to verify it
- Description for the changelog