actions: update permissions and add show-vulnerabilities to security #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusalcantarazup
suggested changes
Sep 28, 2021
nathanmartinszup
approved these changes
Sep 29, 2021
iancardosozup
requested review from
lucasbrunozup and
wiliansilvazup
as code owners
|
This PR contains commits that already been merged on main branch of Horusec. Please rebase your PR with our current main branch. |
This PR depends on a feature i will add, as soon it's ok i'll update the branch |
iancardosozup
added a commit
to ZupIT/horusec-devkit
that referenced
this pull request
Sep 30, 2021
This commit will be used to solve ZupIT/horusec#615 and other repositories in security step to show vulnerabilities but not fail the pipeline Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
iancardosozup
added a commit
that referenced
this pull request
Sep 30, 2021
This commit will be used to solve #615 and other repositories in security step to show vulnerabilities but not fail the pipeline Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
iancardosozup
added a commit
that referenced
this pull request
Sep 30, 2021
This commit will be used to solve #615 and other repositories in security step to show vulnerabilities but not fail the pipeline Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
iancardosozup
added a commit
that referenced
this pull request
Sep 30, 2021
This commit will be used to solve #615 and other repositories in security step to show vulnerabilities but not fail the pipeline Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
iancardosozup
added a commit
that referenced
this pull request
Sep 30, 2021
This commit will be used to solve #615 and other repositories in security step to show vulnerabilities but not fail the pipeline Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
iancardosozup
added a commit
that referenced
this pull request
Oct 1, 2021
This commit will be used to solve #615 and other repositories in security step to show vulnerabilities but not fail the pipeline Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
iancardosozup
added a commit
that referenced
this pull request
Oct 1, 2021
This commit will be used to solve #615 and other repositories in security step to show vulnerabilities but not fail the pipeline Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
iancardosozup
added a commit
that referenced
this pull request
Oct 1, 2021
This commit will be used to solve #615 and other repositories in security step to show vulnerabilities but not fail the pipeline Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
iancardosozup
added a commit
that referenced
this pull request
Oct 1, 2021
This commit will be used to solve #615 and other repositories in security step to show vulnerabilities but not fail the pipeline Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
iancardosozup
added a commit
that referenced
this pull request
Oct 1, 2021
This commit will be used to solve #615 and other repositories in security step to show vulnerabilities but not fail the pipeline Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
Signed-off-by: Ian Cardoso <ian.cardoso@zup.com.br>
| @@ -28,4 +27,5 @@ jobs: | |||
| HORUSEC_CLI_REPOSITORY_NAME: ${{ secrets.HORUSEC_CLI_REPOSITORY_NAME }} | |||
| run: | | |||
| curl -fsSL https://raw.githubusercontent.com/ZupIT/horusec/master/deployments/scripts/install.sh | bash -s latest | |||
| horusec start -p . -e true -G true | |||
| horusec start -p . -e true -G true --show-vulnerabilities-types="Vulnerability, Risk Accepted" | |||
There was a problem hiding this comment.
What do you think about remove the "true" values? They are not necessary when using boolean flags.
There was a problem hiding this comment.
please refer to #637 since we found a bug on PR with fork origin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Cardoso ian.cardoso@zup.com.br
- What I did
Updating permissions to match scorecard standards, but token permissions is still in WIP and it's a problemactic subject on scorecard yet. I will checkout updates to keep us informed about it.
- How to verify it
- Description for the changelog