Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: update permissions and add show-vulnerabilities to security #615

Closed
wants to merge 1 commit into from
Closed

actions: update permissions and add show-vulnerabilities to security #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/alpha.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,13 @@ on:
push:
branches:
- main
permissions: read-all

jobs:
Alpha:
permissions:
contents: write
packages: write
runs-on: ubuntu-latest
env:
COSIGN_KEY_LOCATION: /tmp/cosign.key
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@

name: Build
on: [ "pull_request" ]
permissions: read-all
jobs:
build:
permissions:
contents: read
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, '[skip ci]')"
steps:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@

name: Coverage
on: [ "pull_request" ]
permissions: read-all
jobs:
coverage:
permissions:
contents: read
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, '[skip ci]')"
steps:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/deploy-cli-language.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

name: DeployCLITools

permissions: read-all
on:
workflow_dispatch:
inputs:
Expand All @@ -30,7 +31,7 @@ on:
jobs:
deploy:
permissions:
contents: read
contents: write
name: deploy
runs-on: ubuntu-latest
steps:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,9 @@
name: e2e

on: ["pull_request"]

permissions: read-all
jobs:
e2e-cli:
permissions:
contents: read
name: e2e-cli
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, '[skip ci]')"
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/license.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@

name: License
on: [ "pull_request" ]
permissions: read-all
jobs:
license:
permissions:
contents: read
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, '[skip ci]')"
steps:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@

name: Lint
on: [ "pull_request" ]
permissions: read-all
jobs:
lint:
permissions:
contents: read
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,12 @@ on:
releaseType:
description: 'Release type: M (Major); m (Minor); p (Path)'
required: true

permissions: read-all
jobs:
Release:
permissions:
contents: write
packages: write
runs-on: ubuntu-latest
env:
COSIGN_KEY_LOCATION: /tmp/cosign.key
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/security.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@

name: Security
on: [ "pull_request" ]
permissions: read-all
jobs:
security:
permissions:
contents: read
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -28,4 +27,5 @@ jobs:
HORUSEC_CLI_REPOSITORY_NAME: ${{ secrets.HORUSEC_CLI_REPOSITORY_NAME }}
run: |
curl -fsSL https://raw.githubusercontent.com/ZupIT/horusec/master/deployments/scripts/install.sh | bash -s latest
horusec start -p . -e true -G true
horusec start -p . -e true -G true --show-vulnerabilities-types="Vulnerability, Risk Accepted"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about remove the "true" values? They are not necessary when using boolean flags.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please refer to #637 since we found a bug on PR with fork origin


3 changes: 1 addition & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@

name: Test
on: [ "pull_request" ]
permissions: read-all
jobs:
test:
permissions:
contents: read
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, '[skip ci]')"
steps:
Expand Down
17 changes: 0 additions & 17 deletions horusec-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,23 +22,6 @@
"horusecCliEnableGitHistoryAnalysis": false,
"horusecCliEnableInformationSeverity": false,
"horusecCliFalsePositiveHashes": [
"2eab7620998c54bcbdb1da9ad96f54c3b6ac7b5e0babbff8f502ec10594479ad",
"52ccbcd6c0d13a6af137ba7d5fc6c66a466f7e746256558550e660c82449851b",
"b9f0d3772a885673b4a968d21eb9c350d25aae332b7c1a9bf113b5af24704ff9",
"e8c6a9744859f048a44a4eb160ce0e22df524507a288cfbfcbfcdc26d2533c63",
"9c205ee4b31bea1254f4e8031958995912312a524105469cb49e757d59558496",
"3e64eb0ec371e5ef7d97adec60d3b94cb7dd5a1189951f2a45ed1827e6781d30",
"5fc8f08b377cdc0c92913da73a2d8d8acd85896993e04ae4c15e34ecb829d8b5",
"362a89c4517db256b648e9b1d21ddb0d99018e7c7b9f9b45d200ede54a49363d",
"06f6ce2402e20f1e885e5d59f66db4dde44dfdd2eaf821d86b1d066a707c9fff",
"85492fbc829b64336a4f858022fbe52f05e27ee18d7a8fbdf5ffd23991ebd7a9",
"36f41965e929e9763260c61451ce0a5ca572f8a1a8979390b7c694e54e3dce29",
"c25edc56029ba81e69515d3bca44fa5545af63cf841d8f219ac57fcd7cb95265",
"daf141d66c2b98a3c579726372fbd91957d3e51c00b3a6ec18e5b40ca98fcbe6",
"10415a9f27493234fc73226fd2697c7a4af6ae48bfa8b733ba8fb6693ed44f90",
"8ff7424e06c66ce6264da9c160de02d05c644672de9ec9420a9c1f6f7d632ea0",
"a49902aabb86572896df9baba7d15a5b6db7e968ccd59b88c371bccaefc8fcf2",
"f1721f8345e395a894e4341442a9e22c46eafc4fdf777a8d30ed1cf4f5ea22c1"
],
"horusecCliFilesOrPathsToIgnore": [
"**/e2e/**",
Expand Down