git: improvement on success commit author tests #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
matheusalcantarazup
force-pushed
the
improvement-git-tests
branch
2 times, most recently
from
7f86942 to
718bd4e
Compare
matheusalcantarazup
changed the title
Previously on tests of success getting commit author we was just asserting that the result is not empty, but actually the tests was not getting the correct commit author and was returning commit author not found. This commit add asserts to make sure that we are successful getting the commit author info from a file and line. Signed-off-by: Matheus Alcantara <matheus.alcantara@zup.com.br>
matheusalcantarazup
force-pushed
the
improvement-git-tests
branch
from
718bd4e to
c96cf89
Compare
lucasbrunozup
approved these changes
Oct 11, 2021
iancardosozup
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously on tests of success getting commit author we was just
asserting that the result is not empty, but actually the tests was not
getting the correct commit author and was returning commit author not
found. This commit add asserts to make sure that we are successful
getting the commit author info from a file and line.
Signed-off-by: Matheus Alcantara matheus.alcantara@zup.com.br
- What I did
- How to verify it
- Description for the changelog