Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: improvement on success commit author tests #671

Merged
merged 1 commit into from
Oct 11, 2021
Merged

git: improvement on success commit author tests #671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions internal/services/git/git_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
package git

import (
"path/filepath"
"testing"

"github.com/stretchr/testify/assert"
Expand All @@ -24,7 +25,7 @@ import (

func TestGetCommitAuthor(t *testing.T) {
c := &config.Config{}
c.ProjectPath = "../../../../"
c.ProjectPath = filepath.Join("..", "..", "..")
c.EnableCommitAuthor = true
service := Git{
config: c,
Expand All @@ -33,33 +34,38 @@ func TestGetCommitAuthor(t *testing.T) {
t.Run("Should success get commit author", func(t *testing.T) {
author := service.CommitAuthor("1-2", "README.md")
assert.NotEmpty(t, author.Email)
assert.NotEqual(t, "-", author.Email)
assert.NotEmpty(t, author.Message)
assert.NotEqual(t, "-", author.Message)
assert.NotEmpty(t, author.Author)
assert.NotEqual(t, "-", author.Author)
assert.NotEmpty(t, author.CommitHash)
assert.NotEqual(t, "-", author.CommitHash)
assert.NotEmpty(t, author.Date)
assert.NotEqual(t, "-", author.Date)
})

t.Run("Should return error when something went wrong while executing cmd", func(t *testing.T) {
t.Run("Should return commit author not found when something went wrong while executing cmd", func(t *testing.T) {
author := service.CommitAuthor("999999", "")
assert.Equal(t, author, service.getCommitAuthorNotFound())
})

t.Run("Should return error when line or path not found", func(t *testing.T) {
t.Run("Should return commit author not found when line or path not found", func(t *testing.T) {
author := service.CommitAuthor("1", "-")
assert.Equal(t, author, service.getCommitAuthorNotFound())
})

t.Run("Should return error when parameters is empty", func(t *testing.T) {
t.Run("Should return commit author not found when parameters is empty", func(t *testing.T) {
author := service.CommitAuthor("", "./")
assert.Equal(t, author, service.getCommitAuthorNotFound())
})

t.Run("Should return error when not exists path", func(t *testing.T) {
t.Run("Should return commit author not found when not exists path", func(t *testing.T) {
author := service.CommitAuthor("1", "./some_path")
assert.Equal(t, author, service.getCommitAuthorNotFound())
})

t.Run("Should return empty commit author when invalid output", func(t *testing.T) {
t.Run("Should return commit author not found invalid output", func(t *testing.T) {
author := service.parseOutputToStruct([]byte("test"))
assert.Equal(t, author, service.getCommitAuthorNotFound())
})
Expand Down