Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Change build formulas behavior #332

Merged
merged 3 commits into from
Jul 31, 2020
Merged

Change build formulas behavior #332

merged 3 commits into from
Jul 31, 2020

Conversation

kaduartur
Copy link
Contributor

- What I did

  • Removed docs dir from build formula list
  • Removed --local and added --docker flag
  • Check if build.bat file exist before to build a formula on Windows
  • Add --rm in docker run command
  • Check stderr when to build a formula locally on Windows
  • Remove /bin when the formula building fail
  • Now, formulas containers are built with the same formula name

- How to verify it

  • Run unit tests
  • Create and build a new formula on Windows

- Description for the changelog

@kaduartur kaduartur added 💠 Windows This issue or pull request is specific to the Windows operating system 🚧 WIP Work in Progress 2.0.0 labels Jul 30, 2020
@kaduartur kaduartur self-assigned this Jul 30, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (ritchie-2.0.0@dd29b26). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             ritchie-2.0.0     #332   +/-   ##
================================================
  Coverage                 ?   64.74%           
================================================
  Files                    ?       78           
  Lines                    ?     2533           
  Branches                 ?        0           
================================================
  Hits                     ?     1640           
  Misses                   ?      730           
  Partials                 ?      163           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd29b26...3f87e64. Read the comment docs.

@kaduartur kaduartur added the 🪲 bug Report a bug encountered while operating Ritchie label Jul 30, 2020
@kaduartur kaduartur changed the title Fix build formulas [FIX] build formulas Jul 30, 2020
@fabianofernandeszup
Copy link
Contributor

@kaduartur Is this change to the --docker flag back to how it was in v1?
In v2 shouldn't the docker run be the default?

@sandokandias sandokandias changed the title [FIX] build formulas Change build formulas behavior Jul 31, 2020
@sandokandias sandokandias added 🔨 improvement Improvement in features and removed 🪲 bug Report a bug encountered while operating Ritchie labels Jul 31, 2020
Copy link
Contributor

@sandokandias sandokandias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandokandias sandokandias marked this pull request as ready for review July 31, 2020 14:32
@sandokandias sandokandias merged commit e51a9c8 into ZupIT:ritchie-2.0.0 Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚧 WIP Work in Progress 🔨 improvement Improvement in features 💠 Windows This issue or pull request is specific to the Windows operating system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants