This repository was archived by the owner on Jul 12, 2022. It is now read-only.
Remove image docker post run #334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianofernandeszup
added
🪲 bug
Codecov Report
@@ Coverage Diff @@
## ritchie-2.0.0 #334 +/- ##
=================================================
- Coverage 65.21% 65.19% -0.03%
=================================================
Files 78 78
Lines 2550 2560 +10
=================================================
+ Hits 1663 1669 +6
- Misses 725 727 +2
- Partials 162 164 +2
Continue to review full report at Codecov.
|
sandokandias
suggested changes
Jul 31, 2020
sandokandias
added
🔨 improvement
sandokandias
changed the title
|
this pr https://github.com/ZupIT/ritchie-cli/pull/332/files already fix this bug |
|
Closed in favor of #332 |
|
Nice. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added a command to completely remove the image from the embedded Docker after execution. It will never be reused and takes up a lot of space on the user's computer. Some with almost 2GB.
The current implementation removed only the container.
- How to verify it
Run any formula more than once and you will see that several builds with random ids are generated.
With this implementation, after the execution the image is removed as well as the container.
- Description for the changelog
Added a complete removal of the docker image after execution, to save disk space.
Examples of garbage images before implementation: