Adding flags, delete confirmation and new tests to delete repo #908

fernandobelettizup · 2021-04-16T13:43:22Z

Description

Adding flag support to rit delete repo command. Some of the refactoring done as well in this PR:

Added delete confirmation to rit delete repo prompt execution.
Added tests to support flags and changed tests to work with a tmp directory instead of only mocks.

How to verify it

Run rit delete repo --name=<repo> and check if has been deleted succesfully.
Run rit delete repo and check if the delete confirmation works.

Changelog

Added flag support for rit delete repo command

…rit delete repo Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br>

Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br>

GuillaumeFalourd · 2021-04-19T16:19:40Z

It looks like to use the Input Flags feature, you removed the stdin implementation for the rit delete repo command.
However, as the stdin feature is only deprecated, shouldn't you maintain it as well for compatibility between versions?

pkg/cmd/delete_repo.go

Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br>

pkg/cmd/delete_repo.go

pkg/cmd/delete_repo_test.go

brunasilvazup · 2021-04-19T19:55:17Z

pkg/formula/repo/deleter.go

+	if _, err := os.Stat(repoPath); os.IsNotExist(err) {
+		return errors.New("no repository with this name")
+	}
+


What do you think about adding tests on the deleter_test.go on this rule?

It looks like a great idea, but at the same time it feels like it is already being tested.

deleter_test.go already checks for generic errors inside Delete function. And aiming to check for this specific rule tests should be refactored similarly to what happened to delete_repo_test.go.

On the other hand, on deleter_test.go we assure that any removal error is sent to callers and we certify it on "error to delete repo with wrong name" (delete_repo_test.go line 142).

In this fashion, I am not sure if deleter_test.go should get a refactor issue so this rule could be tested as noted.

In any way deleter_test will still have to be refactored, maybe not necessary on this PR, but we should keep in mind

Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br>

brunasilvazup

👍🏾

GuillaumeFalourd

🚀

kaduartur

Just a simple change!

kaduartur · 2021-04-29T14:56:43Z

pkg/cmd/delete_repo.go

 	return cmd
 }

-func (dr deleteRepoCmd) runFunc() CommandRunnerFunc {
+func (dr deleteRepoCmd) runFormula() CommandRunnerFunc {


Could you rename the function to runCmd?

Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br>

kaduartur · 2021-05-03T14:29:55Z

/merge qa

ritchie-bot · 2021-05-03T14:29:59Z

👌 Merged branch improvement/support-flags-for-rit-delete-repo into qa

kaduartur · 2021-05-03T14:37:11Z

/merge qa

ritchie-bot · 2021-05-03T14:37:15Z

👌 Merged branch improvement/support-flags-for-rit-delete-repo into qa

…#908) * added support flags, added delete confirmation and changed tests for rit delete repo Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fix lint Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * removed "Delete repo STDIN" from stdin_integration_test Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin removal, added local name for flag Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fixing unit tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added nameFlag to error message Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added flag to check if repo must be deleted Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * using missingFlagText method Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * removed existingRepoIsDeleted when value is false from tests struct Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin removed tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin scenarios Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * changed sdtin_feature.json repo url, previous url stopped working Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * chaging test repo tag Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * method renamed runFormula -> runCmd Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br>

* Support flags for the git update repo command. * Support flags for the rit update repo command. * Internationalization Ritchie-cli (#847) * Create config file to ritchie (#825) * Create translation Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create config file Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove unused dependency Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init command (#828) * Improve rit init command Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix functional tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init for Windows Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove comment Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init message Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation for init command (#834) * Add translation for init cmd Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix makefile Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix vendor Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix read config Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation guide Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Update DEVELOPER_GUIDE.md * Fix config_test.go Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Adding flags, delete confirmation and new tests to delete repo (#908) * added support flags, added delete confirmation and changed tests for rit delete repo Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fix lint Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * removed "Delete repo STDIN" from stdin_integration_test Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin removal, added local name for flag Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fixing unit tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added nameFlag to error message Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added flag to check if repo must be deleted Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * using missingFlagText method Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * removed existingRepoIsDeleted when value is false from tests struct Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin removed tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin scenarios Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * changed sdtin_feature.json repo url, previous url stopped working Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * chaging test repo tag Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * method renamed runFormula -> runCmd Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * Feature/add formula rit list formulas (#913) * added list formulas command, changes to tree and builder Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added input flags support Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * creating test file Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added test cases Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * changed check if repo exists logic to avoid for loop Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * tree checker_test fix Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * additional lint fixes (misspelling + preallocation) Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * misspelling fix Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * lint prealloc fix Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * minor suggestion fixes Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added check for empty tree and case tests, changed logic for repo not found Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting error logic on default tree, errors now in list_formula.go Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * lint: misspelling Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added list formula to api.commands Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * simplified a var declaration Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added missingFlagText, changes to constructor and flag description Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added asserts for printed output Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * ignoring print errors on ALL flag, added warning Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added test case to check warning Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * changed method name, list repos logic, replacer logic, empty repo warning and tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * simplified printformulas to return warnings, changed tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * lint fix -> no error returning from printFormulas, just warnings Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fixing merge buid conflict Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * Removal of the Run FuncEF method that I had created. Standardize methods according to other commands. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Remove comment Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Adjust in return to perform only an update repo on runCmd. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Variable renamed with a more complete name. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Linter Fix, gofmt. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Fix version update prompt, fix array lenght in update flags Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Change error msg Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Change return 'err' to nil Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * add 'externalRepos', with only remote repositorys Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * change err to nil Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * change err to nil Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * First tests Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * gofmt file Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * small changes and working tests Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * All Tests Working, Need Refactor Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Working Tests with assert Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Last test, invalid repo Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Change output error to fmt.Errorf Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * remove variable flagAll Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * declaration of success message in just one place Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * addition of the help message addition of the help message Co-authored-by: Kadu Artur Prussek <kadu.artur@gmail.com> Co-authored-by: fernandobelettizup <60020008+fernandobelettizup@users.noreply.github.com>

added support flags, added delete confirmation and changed tests for …

76d17af

…rit delete repo Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br>

fernandobelettizup requested review from brunasilvazup, henriquemoraeszup, kaduartur, lucasdittrichzup and rodrigomedeirosf as code owners April 16, 2021 13:43

fernandobelettizup mentioned this pull request Apr 16, 2021

Add tests and Support flags for rit delete repo #718

Closed

2 tasks

fernandobelettizup linked an issue Apr 16, 2021 that may be closed by this pull request

Add tests and Support flags for rit delete repo #718

Closed

2 tasks

fernandobelettizup added 🚧 WIP Work in Progress 🔨 improvement Improvement in features labels Apr 16, 2021

fernandobelettizup added 2 commits April 16, 2021 10:54

fix lint

97001f3

Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br>

removed "Delete repo STDIN" from stdin_integration_test

e53cfcb

Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br>

fernandobelettizup added ✔️ ready-for-review ready for review and removed 🚧 WIP Work in Progress labels Apr 16, 2021

fernandobelettizup self-assigned this Apr 16, 2021

brunasilvazup reviewed Apr 19, 2021

View reviewed changes

pkg/cmd/delete_repo.go Outdated Show resolved Hide resolved

reverting stdin removal, added local name for flag

2475894

Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br>

fernandobelettizup added 🚧 WIP Work in Progress and removed ✔️ ready-for-review ready for review labels Apr 19, 2021

fixing unit tests

2e56dfe

Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br>

fernandobelettizup added ✔️ ready-for-review ready for review and removed 🚧 WIP Work in Progress labels Apr 19, 2021

fernandobelettizup requested review from brunasilvazup and GuillaumeFalourd April 19, 2021 18:52

brunasilvazup reviewed Apr 19, 2021

View reviewed changes

pkg/cmd/delete_repo.go Outdated Show resolved Hide resolved

brunasilvazup reviewed Apr 19, 2021

View reviewed changes

pkg/cmd/delete_repo_test.go Show resolved Hide resolved

brunasilvazup reviewed Apr 19, 2021

View reviewed changes

pkg/cmd/delete_repo_test.go Outdated Show resolved Hide resolved

brunasilvazup reviewed Apr 19, 2021

View reviewed changes

added nameFlag to error message

4d27d76

Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br>

fernandobelettizup added the 🚧 WIP Work in Progress label Apr 23, 2021

reverting stdin scenarios

1dcbacf

Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br>

fernandobelettizup dismissed brunasilvazup’s stale review via 1dcbacf April 23, 2021 21:25

fernandobelettizup added ✔️ ready-for-review ready for review and removed 🚧 WIP Work in Progress labels Apr 23, 2021

fernandobelettizup added 2 commits April 23, 2021 18:46

changed sdtin_feature.json repo url, previous url stopped working

77b955b

Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br>

chaging test repo tag

6ce866f

Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br>

fernandobelettizup requested a review from brunasilvazup April 26, 2021 12:05

henriquemoraeszup previously approved these changes Apr 26, 2021

View reviewed changes

brunasilvazup previously approved these changes Apr 26, 2021

View reviewed changes

GuillaumeFalourd previously approved these changes Apr 26, 2021

View reviewed changes

kaduartur suggested changes Apr 29, 2021

View reviewed changes

method renamed runFormula -> runCmd

749962d

Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br>

fernandobelettizup dismissed stale reviews from GuillaumeFalourd, brunasilvazup, and henriquemoraeszup via 749962d April 29, 2021 15:03

fernandobelettizup requested review from kaduartur, GuillaumeFalourd, henriquemoraeszup and brunasilvazup April 29, 2021 16:24

kaduartur approved these changes May 3, 2021

View reviewed changes

kaduartur added the 🚀 QA label May 3, 2021

kaduartur merged commit ec0f223 into ZupIT:master May 3, 2021

GuillaumeFalourd mentioned this pull request May 10, 2021

Add rit delete repo input flags option ZupIT/ritchie-docs#68

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding flags, delete confirmation and new tests to delete repo #908

Adding flags, delete confirmation and new tests to delete repo #908

fernandobelettizup commented Apr 16, 2021

GuillaumeFalourd commented Apr 19, 2021

brunasilvazup Apr 19, 2021

fernandobelettizup Apr 19, 2021

henriquemoraeszup Apr 23, 2021

brunasilvazup left a comment

GuillaumeFalourd left a comment

kaduartur left a comment

kaduartur Apr 29, 2021

kaduartur commented May 3, 2021

ritchie-bot bot commented May 3, 2021

kaduartur commented May 3, 2021

ritchie-bot bot commented May 3, 2021

Adding flags, delete confirmation and new tests to delete repo #908

Adding flags, delete confirmation and new tests to delete repo #908

Conversation

fernandobelettizup commented Apr 16, 2021

Description

How to verify it

Changelog

GuillaumeFalourd commented Apr 19, 2021

brunasilvazup Apr 19, 2021

Choose a reason for hiding this comment

fernandobelettizup Apr 19, 2021

Choose a reason for hiding this comment

henriquemoraeszup Apr 23, 2021

Choose a reason for hiding this comment

brunasilvazup left a comment

Choose a reason for hiding this comment

GuillaumeFalourd left a comment

Choose a reason for hiding this comment

kaduartur left a comment

Choose a reason for hiding this comment

kaduartur Apr 29, 2021

Choose a reason for hiding this comment

kaduartur commented May 3, 2021

ritchie-bot bot commented May 3, 2021

kaduartur commented May 3, 2021

ritchie-bot bot commented May 3, 2021