Support flags for the rit update repo command. #916

maurineimirandazup · 2021-05-03T22:09:08Z

Description

Allows the use of flags in the rit update repo command

How to verify it

Update a remote repository using the command rit update repo --name="repository_name" --version="1.2"

Changelog

A new method for executing commands from the Cobra library has been introduced. Which allows the user to add the 3 different methods. (ie: run with stdin, flags or prompt)

…andazup/ritchie-cli into mm/update-repo-flags

pkg/cmd/cmd.go

pkg/cmd/update_repo.go

pkg/cmd/cmd.go

* Create config file to ritchie (ZupIT#825) * Create translation Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create config file Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove unused dependency Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init command (ZupIT#828) * Improve rit init command Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix functional tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init for Windows Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove comment Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init message Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation for init command (ZupIT#834) * Add translation for init cmd Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix makefile Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix vendor Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix read config Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation guide Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Update DEVELOPER_GUIDE.md * Fix config_test.go Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

…#908) * added support flags, added delete confirmation and changed tests for rit delete repo Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fix lint Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * removed "Delete repo STDIN" from stdin_integration_test Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin removal, added local name for flag Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fixing unit tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added nameFlag to error message Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added flag to check if repo must be deleted Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * using missingFlagText method Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * removed existingRepoIsDeleted when value is false from tests struct Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin removed tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin scenarios Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * changed sdtin_feature.json repo url, previous url stopped working Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * chaging test repo tag Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * method renamed runFormula -> runCmd Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br>

* added list formulas command, changes to tree and builder Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added input flags support Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * creating test file Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added test cases Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * changed check if repo exists logic to avoid for loop Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * tree checker_test fix Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * additional lint fixes (misspelling + preallocation) Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * misspelling fix Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * lint prealloc fix Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * minor suggestion fixes Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added check for empty tree and case tests, changed logic for repo not found Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting error logic on default tree, errors now in list_formula.go Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * lint: misspelling Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added list formula to api.commands Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * simplified a var declaration Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added missingFlagText, changes to constructor and flag description Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added asserts for printed output Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * ignoring print errors on ALL flag, added warning Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added test case to check warning Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * changed method name, list repos logic, replacer logic, empty repo warning and tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * simplified printformulas to return warnings, changed tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * lint fix -> no error returning from printFormulas, just warnings Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fixing merge buid conflict Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br>

…ods according to other commands. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

codecov-commenter · 2021-05-06T21:36:51Z

Codecov Report

Merging #916 (3eea57a) into master (57d8fdb) will decrease coverage by 0.08%.
The diff coverage is 89.24%.

@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
- Coverage   85.55%   85.46%   -0.09%     
==========================================
  Files         118      118              
  Lines        4305     4355      +50     
==========================================
+ Hits         3683     3722      +39     
- Misses        417      423       +6     
- Partials      205      210       +5

Impacted Files	Coverage Δ
pkg/cmd/update_repo.go	`90.35% <89.24%> (-9.65%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe8d5a...3eea57a. Read the comment docs.

pkg/cmd/update_repo.go

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

…andazup/ritchie-cli into mm/update-repo-flags

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

changes made, waiting for tests to make another review

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

pkg/cmd/update_repo.go

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

lucasdittrichzup · 2021-05-20T19:56:06Z

LGTM 🚀

pkg/cmd/update_repo.go

addition of the help message

GuillaumeFalourd

Good job 👍🏼

Support flags for the git update repo command.

9d7b1b2

maurineimirandazup requested review from brunasilvazup, fernandobelettizup, henriquemoraeszup, kaduartur, lucasdittrichzup and rodrigomedeirosf as code owners May 3, 2021 22:09

maurineimirandazup linked an issue May 3, 2021 that may be closed by this pull request

Support flags for rit update repo #722

Closed

maurineimirandazup added 🚧 WIP Work in Progress good first issue Good for newcomers 🔨 improvement Improvement in features and removed good first issue Good for newcomers labels May 3, 2021

maurineimirandazup changed the title ~~Support flags for the git update repo command.~~ Support flags for the rit update repo command. May 3, 2021

maurineimirandazup added 2 commits May 3, 2021 19:12

Support flags for the rit update repo command.

5306c87

Merge branch 'mm/update-repo-flags' of https://github.com/maurineimir…

5031ca6

…andazup/ritchie-cli into mm/update-repo-flags

fabianofernandeszup reviewed May 4, 2021

View reviewed changes

pkg/cmd/cmd.go Outdated Show resolved Hide resolved

pkg/cmd/update_repo.go Outdated Show resolved Hide resolved

pkg/cmd/update_repo.go Outdated Show resolved Hide resolved

fernandobelettizup reviewed May 4, 2021

View reviewed changes

pkg/cmd/cmd.go Outdated Show resolved Hide resolved

kaduartur and others added 8 commits May 4, 2021 17:48

Removal of the Run FuncEF method that I had created. Standardize meth…

9210f06

…ods according to other commands. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

Remove comment

33df5e4

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

Adjust in return to perform only an update repo on runCmd.

7584106

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

Merge remote-tracking branch 'upstream/master' into mm/update-repo-flags

9bcc594

Variable renamed with a more complete name.

4897528

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

maurineimirandazup requested review from fernandobelettizup and fabianofernandeszup May 6, 2021 21:27

Linter Fix, gofmt.

bdca280

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

fernandobelettizup suggested changes May 7, 2021

View reviewed changes

pkg/cmd/update_repo.go Show resolved Hide resolved

pkg/cmd/update_repo.go Outdated Show resolved Hide resolved

maurineimirandazup added 5 commits May 11, 2021 11:12

add 'externalRepos', with only remote repositorys

b88f7f2

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

change err to nil

b54f171

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

change err to nil

e7f000a

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

Merge branch 'mm/update-repo-flags' of https://github.com/maurineimir…

610ea21

…andazup/ritchie-cli into mm/update-repo-flags

First tests

7e2fc8d

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

maurineimirandazup requested a review from GuillaumeFalourd as a code owner May 12, 2021 19:55

fernandobelettizup previously approved these changes May 12, 2021

View reviewed changes

maurineimirandazup added 6 commits May 13, 2021 11:26

gofmt file

2862841

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

small changes and working tests

a921ef7

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

All Tests Working, Need Refactor

d37607d

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

Working Tests with assert

b4bc96f

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

Last test, invalid repo

8757e47

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

Change output error to fmt.Errorf

bee0d1a

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

maurineimirandazup added ✔️ ready-for-review ready for review and removed waiting reply Waiting for an answer to a comment labels May 19, 2021

maurineimirandazup requested review from brunasilvazup and fernandobelettizup May 20, 2021 13:32

lucasdittrichzup previously approved these changes May 20, 2021

View reviewed changes

pkg/cmd/update_repo.go Outdated Show resolved Hide resolved

pkg/cmd/update_repo.go Outdated Show resolved Hide resolved

maurineimirandazup added 2 commits May 20, 2021 11:44

remove variable flagAll

4c002ff

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

declaration of success message in just one place

0545a5f

Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br>

maurineimirandazup dismissed lucasdittrichzup’s stale review via 0545a5f May 20, 2021 16:39

maurineimirandazup requested a review from lucasdittrichzup May 20, 2021 16:43

lucasdittrichzup previously approved these changes May 20, 2021

View reviewed changes

GuillaumeFalourd reviewed May 20, 2021

View reviewed changes

pkg/cmd/update_repo.go Outdated Show resolved Hide resolved

addition of the help message

3eea57a

addition of the help message

maurineimirandazup dismissed lucasdittrichzup’s stale review via 3eea57a May 21, 2021 13:06

GuillaumeFalourd approved these changes May 21, 2021

View reviewed changes

GuillaumeFalourd merged commit 6033181 into ZupIT:master May 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support flags for the rit update repo command. #916

Support flags for the rit update repo command. #916

maurineimirandazup commented May 3, 2021

codecov-commenter commented May 6, 2021 •

edited

Loading

lucasdittrichzup commented May 20, 2021

GuillaumeFalourd left a comment

Support flags for the rit update repo command. #916

Support flags for the rit update repo command. #916

Conversation

maurineimirandazup commented May 3, 2021

Description

How to verify it

Changelog

codecov-commenter commented May 6, 2021 • edited Loading

Codecov Report

lucasdittrichzup commented May 20, 2021

GuillaumeFalourd left a comment

Choose a reason for hiding this comment

codecov-commenter commented May 6, 2021 •

edited

Loading