fix: export transport agnostic errors from client#272
Conversation
Summary of ChangesHello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a naming conflict by relocating the export of several transport-agnostic error types. These errors, previously intended for re-export from Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🧪 Code Coverage
Generated by coverage-comment.yml |
There was a problem hiding this comment.
Code Review
This pull request refactors error exports to resolve a naming conflict, which is a good improvement. My review includes a few suggestions to enhance code style and documentation clarity. Specifically, I recommend sorting the new exports in src/client/index.ts for better readability and adjusting the comments in src/errors.ts to ensure both the error codes and classes have clear, distinct documentation.
ad8ac63 to
1bfdcc8
Compare
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.3.7](v0.3.6...v0.3.7) (2025-12-17) ### Features * add rest client ([#258](#258)) ([96be3a1](96be3a1)) * remove EventEmitter dependency to support Edge Runtime ([#219](#219)) ([6c76fef](6c76fef)), closes [#218](#218) ### Bug Fixes * export transport agnostic errors from client ([#272](#272)) ([23cd42e](23cd42e)) * pass ServerCallContext to getAuthenticatedExtendedAgentCard for REST ([#274](#274)) ([89b141b](89b141b)), closes [#137](#137) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Description
Due to a name conflict with legacy JSON-RPC types reexported from
src/index.tsbelow errors are going to be exported viasrc/client/index.tsto allow usage from external transport implementations.