fix: pass ServerCallContext to getAuthenticatedExtendedAgentCard for REST#274
fix: pass ServerCallContext to getAuthenticatedExtendedAgentCard for REST#274
Conversation
Summary of ChangesHello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a fix to ensure that the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🧪 Code Coverage
Generated by coverage-comment.yml |
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a bug by passing the ServerCallContext to the getAuthenticatedExtendedAgentCard method in the REST transport layer. The changes in rest_handler.ts and rest_transport_handler.ts ensure that authentication context is available for retrieving the agent card, which aligns with the PR's goal. The implementation is straightforward and well-executed. I have reviewed the changes and found no issues.
🤖 I have created a release *beep* *boop* --- ## [0.3.7](v0.3.6...v0.3.7) (2025-12-17) ### Features * add rest client ([#258](#258)) ([96be3a1](96be3a1)) * remove EventEmitter dependency to support Edge Runtime ([#219](#219)) ([6c76fef](6c76fef)), closes [#218](#218) ### Bug Fixes * export transport agnostic errors from client ([#272](#272)) ([23cd42e](23cd42e)) * pass ServerCallContext to getAuthenticatedExtendedAgentCard for REST ([#274](#274)) ([89b141b](89b141b)), closes [#137](#137) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Description
Follow-up for #142: authenticated agent card logic relies on context to determine authentication status.
src/server/transports/rest/rest_transport_handler.tsis not exported, so adding a required parameter is fine.Re #137