update local repo main #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added _scproxy necessary for MacOS Signed-off-by: changyonglik <theeahlag@gmail.com> * Changed to conditional import Signed-off-by: changyonglik <theeahlag@gmail.com> * Added comments Signed-off-by: changyonglik <theeahlag@gmail.com> Signed-off-by: changyonglik <theeahlag@gmail.com>
* Create consume-features.md * Update consume-features.md * rename docs * Update model-inference-with-feathr.md * Update README.md * update docs per feedback * Update streaming-source-ingestion.md * update docs * update docs * Update azure-deployment-arm.md * Update model-inference-with-feathr.md * add sign off message Signed-off-by: Xiaoyong Zhu xiaoyzhu@outlook.com * fix comments * Delete deploy-feathr-api-as-webapp.md * Update model-inference-with-feathr.md Signed-off-by: Xiaoyong Zhu xiaoyzhu@outlook.com
* Clean up after moving to LFAI Clean up after moving to LFAI * Update README.md
…image (#668) * Adding DevSkim linter to Github actions * Fix in ARM template to pull latest tagged release image from dockerhub * Removing dev skim file from this branch * Fixing linkedin org reference
* Added prettier documentation Signed-off-by: changyonglik <theeahlag@gmail.com> * Fixed prettier documentation Signed-off-by: changyonglik <theeahlag@gmail.com> Signed-off-by: changyonglik <theeahlag@gmail.com>
UI: Add data source detail page
* squash commit and avoid conflict * Revert legacy purview client issue * Fix typo * Remove auth from assink * Update aerospike guidance document * Chaneg port param to int
* extend rbac to support project id as input Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com> * update registry docs and interface Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com> * user name case sensitive hot fix Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com> Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
…al spark (#644) * local spark feature join job with local file * update local spark with udf support * add feature gen support in local spark * update test case * remove unused feature conf, update doc * expose master as input and refine local spark provider Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
Fixes #685 Look at the screenshot in the issue with the fixes. Basically it seems for dockerhub images, we don't need to pass in the full URL (domain name) for the image name while publishing them to webapps.
* Update setup.py * Update setup.py * Update setup.py
* Apply 'aggregation_features' parameter to merge dataframes * modify test cases * modify test case filter rule to keep same results as before * add typekey check and improve previous changes * merge to main and quick change * revert change by mistake * Apply this parameter to HDSF sink and add comments * quick fix * quick improve Co-authored-by: Enya-Yx <enya@v-ellinlu-2.fareast.corp.microsoft.com> Co-authored-by: enya-yx <enya@7633599-06281.northamerica.corp.microsoft.com> Co-authored-by: enya-yx <enya@LAPTOP-NBH6175C.redmond.corp.microsoft.com>
Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
When using old purview client (not registry client), if features inside an anchor has a same SET of keys , when calling get_feature_from_registry, only the first key will be used. This PR handles the situation where each feature has multiple keys, and the collection of keys are identical among features inside an anchor.
* Fix Feature value adaptor and UDF adaptor on Spark executors * Fix path with #LATEST * Add comments * Defer version bump
Right now the SQL registry returns all errors as 500 Internal Error, this PR improves the error handling and returns 400/404/409 on corresponding criteria. Also it introduces an environment variable REGISTRY_DEBUGGING, the returned HTTP error will include the detailed track back info when it's set to non-empty string. This variable should only be used for debugging purposes.
Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com> Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
… when all the feature types are not provided (#701)
Resolves #699 Root cause: Purview Registry starts too slow (than SQL registry) while RBAC layer add a dependency to its API in RBAC init which causes the web app crash Trials and Fix Trial: Add a sleep(60) command in start.sh will make the deployment successful Fix: Move the registry api dependency outside of RBAC init; Log the failure as Runtime Exception
Remove hard coded resources, such as synapse, app endpoint, redis and so on in docs to avoid causing confusion.
* Add e2e test for purview registry and rbac registry * Add purview and rbac env e2e to registry tests * Fix merge issue
Enhance databricks submission error message
* Enhance purview registry error messages * Update doc for REGISTRY_DEBUGGING
Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com> Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
* Fix materialize to sql e2e test failure * Update sql server name
Signed-off-by: Boli Guan <ifendoe@gmail.com>
* UI: Display version Signed-off-by: Boli Guan <ifendoe@gmail.com> * Update the version of the package.json * Update feathr_overall_release_guide.md Signed-off-by: Boli Guan <ifendoe@gmail.com>
* add nightly notification to test Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com> add daily notification to pr test * update message Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com> Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com> Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
* Fix test_azure_spark_maven_e2e ci test error * Update test_azure_kafka_e2e.py * Update test_azure_spark_maven_e2e.py
Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com> Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
…#795) * Adding DevSkim linter to Github actions * Update docker-publish.yml * Update docker-publish.yml * Update docker-publish.yml * Update docker-publish.yml * Update docker-publish.yml * Update docker-publish.yml * Update docker-publish.yml * Update docker-publish.yml * Removing devskim file * Restructuring the Prod Reco sample * Adjusting headings * Minor changes * Removing changes to docker publish file * Addressing PR comments, moving Product recommendation notebook sample to Synapse folder since it is strongly tied to Synapse * Addressing PR comments * Fixing images * Removing the need to pass email id as we could directly compute object Id using az command, also making CLI instructions clearer that it is for advance users * Fixing typos * Combining product_reco and product_reco_advanced into one notebook * Updating release guide with maven automated workflow information * Removing notebook changes in this PR
This PR fixes dead links detected in latest ci run. The doc scan ci action has been updated to run on main only, as running this in PR frequently reports false alarm due to changes in CI not deployed.
* Add DataSourcesSelect and FlowGraph and ResizeTable components. Fix all warning and lint issues. Signed-off-by: Boli Guan <ifendoe@gmail.com> * Add CardDescriptions component and fix ESlint warning. Signed-off-by: Boli Guan <ifendoe@gmail.com> * Update FeatureDetails page title. Signed-off-by: Boli Guan <ifendoe@gmail.com> * Rename ProjectSelect Signed-off-by: Boli Guan <ifendoe@gmail.com> Signed-off-by: Boli Guan <ifendoe@gmail.com>
* Add release instructions for Release Candidate * Add a section for release versioning * Add a section for overall process triggered by the release manager
Co-authored-by: Bozhong Hu <bobhu@linkedin.com>
* Replacing the web app deploy (which is buggy) with a simpler action that calls the webhook URL of the deployed App Service * Using the latest version of webhook and corresponding fields with it, this version makes the webhook_secret optional
Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
Signed-off-by: Boli Guan <ifendoe@gmail.com> Signed-off-by: Boli Guan <ifendoe@gmail.com>
* fix sample issues due to derived feature engine change * add `allow_materialize_non_agg_feature` param in notebooks * add all tenant when logging in * Update _synapse_submission.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #XXX
How was this PR tested?
Does this PR introduce any user-facing changes?