Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dream): re-export dream-pure library #291

Closed
wants to merge 1 commit into from

Conversation

glennsl
Copy link
Contributor

@glennsl glennsl commented Jul 24, 2023

Using the template preprocessor assumes dream-pure is re-exported, which it won't be if implicit_transitive_deps is disabled in the consuming project, unless the library is explicitly re-exported. This does that.

For more information:

@aantron aantron closed this in 9938850 Nov 12, 2023
@aantron
Copy link
Owner

aantron commented Nov 12, 2023

Thanks! This was actually an oversight. The templater should have been emitting Dream.html_escape. Probably left over from some refactoring. The templater uses the Dream module directly in other code it emits. I tested the templater against a version of example 7-template with (implicit_transitive_deps false) and it now works.

@glennsl glennsl deleted the patch-1 branch November 13, 2023 09:39
@samoht
Copy link
Contributor

samoht commented Apr 10, 2024

I think this breaks MirageOS support, as now you need to depend on dream when using eml files

@aantron
Copy link
Owner

aantron commented May 27, 2024

@samoht As I understand it, dream-mirage already depends on dream. Do you mean something extra?

@samoht
Copy link
Contributor

samoht commented May 30, 2024

It doesn't depend on dream in the dune file

@aantron
Copy link
Owner

aantron commented Sep 5, 2024

@hannesm, @dinosaure, could you comment on whether this indeed breaks Mirage? I'm ready to revert 9938850 and merge in the original commit here, if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants