Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dream 1.0.0~alpha6 #25949

Merged
merged 2 commits into from
May 28, 2024
Merged

Dream 1.0.0~alpha6 #25949

merged 2 commits into from
May 28, 2024

Conversation

aantron
Copy link
Contributor

@aantron aantron commented May 27, 2024

From the changelog:

Additions

Removals

  • Remove previously deprecated values Dream.with_client, Dream.with_method, Dream.with_header, Dream.with_body, Dream.with_stream, Dream.write_buffer, Dream.form_tag, Dream.session, Dream.put_session, Dream.all_session_values, Dream.put_flash, Dream.local, Dream.new_local, Dream.with_local, Dream.first, Dream.last, and deprecated type Dream.local (aantron/dream@e14bd91).

Fixes

Miscellaneous

@aantron
Copy link
Contributor Author

aantron commented May 28, 2024

Looking at and addressing the failures.

@aantron
Copy link
Contributor Author

aantron commented May 28, 2024

I've...

  • Changed the checksum to SHA-256.
  • Opened an issue on FPauth-core about adapting to changes in Dream, and constrained the existing release.
  • Added package result as a dependency of dream-serve. I will remove this dependency upstream in dream-serve when I next maintain it.
  • Constrained hyper. I will adapt it to the latest Dream when I next maintain it.

The remaining failures look to be in dependencies of Dream, and not related to Dream.

@mseri
Copy link
Member

mseri commented May 28, 2024

The lower bound failure is of luv


#=== ERROR while compiling luv.0.5.0 ==========================================#
# context              2.2.0~beta3~dev | linux/x86_64 | ocaml-base-compiler.4.08.1 | file:///home/opam/opam-repository
# path                 ~/.opam/4.08/.opam-switch/build/luv.0.5.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p luv -j 255
# exit-code            1
# env-file             ~/.opam/log/luv-7-7f592f.env
# output-file          ~/.opam/log/luv-7-7f592f.out
### output ###
#      python3 src/c/dlluv.so,src/c/libuv.a (exit 1)
# (cd _build/default/src/c/vendor/libuv && /usr/bin/python3 gyp_uv.py -f make -Duv_library=static_library)
# /home/opam/.opam/4.08/.opam-switch/build/luv.0.5.0/_build/default/src/c/vendor/libuv/build/gyp/pylib/gyp/input.py:1186: SyntaxWarning: "is" with a literal. Did you mean "=="?
#   if the_dict_key is 'variables' and variable_name in the_dict:
# Traceback (most recent call last):
#   File "/home/opam/.opam/4.08/.opam-switch/build/luv.0.5.0/_build/default/src/c/vendor/libuv/gyp_uv.py", line 21, in <module>
#     import gyp
#   File "/home/opam/.opam/4.08/.opam-switch/build/luv.0.5.0/_build/default/src/c/vendor/libuv/build/gyp/pylib/gyp/__init__.py", line 10, in <module>
#     import gyp.input
#   File "/home/opam/.opam/4.08/.opam-switch/build/luv.0.5.0/_build/default/src/c/vendor/libuv/build/gyp/pylib/gyp/input.py", line 8, in <module>
#     import gyp.common
#   File "/home/opam/.opam/4.08/.opam-switch/build/luv.0.5.0/_build/default/src/c/vendor/libuv/build/gyp/pylib/gyp/common.py", line 497, in <module>
#     class OrderedSet(collections.MutableSet):
#                      ^^^^^^^^^^^^^^^^^^^^^^
# AttributeError: module 'collections' has no attribute 'MutableSet'

That depends on the python version and we cannot do much about it: the attribute MutableMapping from the module collections got moved into collections.abc in python3.10.

@mseri
Copy link
Member

mseri commented May 28, 2024

Thanks a lot. This looks fine to merge

@mseri mseri merged commit 2786d01 into ocaml:master May 28, 2024
1 check was pending
@aantron
Copy link
Contributor Author

aantron commented May 28, 2024

Thank you!

The lower bound failure is of luv

This is only present in an old version of Luv that used a Python-based build process for the vendored libuv, whereas Luv since then switched to dumping an autotools build system for libuv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants