Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two jwt libraries #116

Closed
sethvargo opened this issue Sep 15, 2022 · 0 comments · Fixed by #119
Closed

Two jwt libraries #116

sethvargo opened this issue Sep 15, 2022 · 0 comments · Fixed by #119
Labels
bug Something isn't working
Milestone
MVP cleanup

Comments

@sethvargo
Copy link
Contributor

TL;DR

There are two jwt libraries in JVS. One defines jwt.Token as struct, and the other defines it as an interface. We should standardize on a single jwt library.

Expected behavior

Single jwt library

Observed behavior

Both github.com/golang-jwt/jwt and github.com/lestrrat-go/jwx/v2/jwt libraries.

Environment Details

N/A

Additional information

No response
@sethvargo sethvargo added the bug Something isn't working label Sep 15, 2022
sethvargo added a commit that referenced this issue Sep 15, 2022
@sethvargo
Don't use a pointer to an interface
21743e9 
This is part of a cleanup for #116. In golang-jwt, Token is a struct. In jwx, it's an interface. Returning a pointer to an interface is generally frowned upon. This changes the interface to always be returned as an interface, but there needs to be a larger effort around reducing to a single jwt library.
This was referenced Sep 15, 2022
Merged
Merged
sethvargo added a commit that referenced this issue Sep 15, 2022
@sethvargo
Don't use a pointer to an interface (#117)
db26d44 
This is part of a cleanup for #116. In golang-jwt, Token is a struct. In jwx, it's an interface. Returning a pointer to an interface is generally frowned upon. This changes the interface to always be returned as an interface, but there needs to be a larger effort around reducing to a single jwt library.
@yolocs yolocs added this to the MVP cleanup milestone Sep 20, 2022
@sethvargo sethvargo mentioned this issue Sep 21, 2022
Merged
sqin2019 pushed a commit that referenced this issue Apr 6, 2023
@sethvargo
Don't use a pointer to an interface (#117)
82727c9 
This is part of a cleanup for #116. In golang-jwt, Token is a struct. In jwx, it's an interface. Returning a pointer to an interface is generally frowned upon. This changes the interface to always be returned as an interface, but there needs to be a larger effort around reducing to a single jwt library.
verbanicm pushed a commit that referenced this issue Jun 14, 2023
@sethvargo @verbanicm
Don't use a pointer to an interface (#117)
8a5acf1 
This is part of a cleanup for #116. In golang-jwt, Token is a struct. In jwx, it's an interface. Returning a pointer to an interface is generally frowned upon. This changes the interface to always be returned as an interface, but there needs to be a larger effort around reducing to a single jwt library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
MVP cleanup
Development

Successfully merging a pull request may close this issue.

Switch to using a single JWT library and unify api package abcxyz/jvs
2 participants
@sethvargo @yolocs