Don't use a pointer to an interface #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of a cleanup for #116. In golang-jwt, Token is a struct. In jwx, it's an interface. Returning a pointer to an interface is generally frowned upon. This changes the interface to always be returned as an interface, but there needs to be a larger effort around reducing to a single jwt library.
This was referenced Sep 15, 2022
myurtoglu
approved these changes
Sep 15, 2022
sqin2019
pushed a commit
that referenced
this pull request
Apr 6, 2023
This is part of a cleanup for #116. In golang-jwt, Token is a struct. In jwx, it's an interface. Returning a pointer to an interface is generally frowned upon. This changes the interface to always be returned as an interface, but there needs to be a larger effort around reducing to a single jwt library.
verbanicm
pushed a commit
that referenced
this pull request
Jun 14, 2023
This is part of a cleanup for #116. In golang-jwt, Token is a struct. In jwx, it's an interface. Returning a pointer to an interface is generally frowned upon. This changes the interface to always be returned as an interface, but there needs to be a larger effort around reducing to a single jwt library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a cleanup for #116. In golang-jwt, Token is a struct. In jwx, it's an interface. Returning a pointer to an interface is generally frowned upon. This changes the interface to always be returned as an interface, but there needs to be a larger effort around reducing to a single jwt library.