Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token reason should have a size limit (or with truncate) #170

Closed
yolocs opened this issue Jan 24, 2023 · 0 comments · Fixed by #177
Closed

Token reason should have a size limit (or with truncate) #170

yolocs opened this issue Jan 24, 2023 · 0 comments · Fixed by #177
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@yolocs
Copy link
Contributor

yolocs commented Jan 24, 2023

TL;DR

The size limit of a HTTP header is 8KB which marks our upper limit for the token size. So for the reason, we should limit to something much lower, like 2KB.

Detailed design

No response

Alternatives considered

No response

Additional information

No response
@yolocs yolocs added enhancement New feature or request good first issue Good for newcomers labels Jan 24, 2023
sethvargo added a commit that referenced this issue Jan 25, 2023
@sethvargo
Limit size on justifications
34c66a5 
This isn't a perfect solution because there's some error during JSON marshalling, but I don't think we should take the overhead of marshalling the JSON.

Fixes GH-170
@sethvargo sethvargo mentioned this issue Jan 25, 2023
Merged
sethvargo added a commit that referenced this issue Jan 26, 2023
@sethvargo
Limit size on justifications (#177)
2200787 
This isn't a perfect solution because there's some error during JSON marshalling, but I don't think we should take the overhead of marshalling the JSON.

Fixes GH-170
sqin2019 pushed a commit that referenced this issue Apr 6, 2023
@sethvargo
Limit size on justifications (#177)
c6e064f 
This isn't a perfect solution because there's some error during JSON marshalling, but I don't think we should take the overhead of marshalling the JSON.

Fixes GH-170
verbanicm pushed a commit that referenced this issue Jun 14, 2023
@sethvargo @verbanicm
Limit size on justifications (#177)
cc6da44 
This isn't a perfect solution because there's some error during JSON marshalling, but I don't think we should take the overhead of marshalling the JSON.

Fixes GH-170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Limit size on justifications abcxyz/jvs
1 participant
@yolocs