Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit size on justifications #177

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Limit size on justifications #177

merged 1 commit into from
Jan 26, 2023

Conversation

sethvargo
Copy link
Contributor

This isn't a perfect solution because there's some error during JSON marshalling, but I don't think we should take the overhead of marshalling the JSON.

Fixes GH-170

This isn't a perfect solution because there's some error during JSON marshalling, but I don't think we should take the overhead of marshalling the JSON.

Fixes GH-170
@sethvargo sethvargo requested review from a team, capri-xiyue, sailorlqh and yolocs January 25, 2023 01:11
@sethvargo sethvargo enabled auto-merge (squash) January 25, 2023 01:24
@sethvargo
Copy link
Contributor Author

Ping @yolocs

@sethvargo sethvargo merged commit 2200787 into main Jan 26, 2023
@sethvargo sethvargo deleted the sethvargo/limits branch January 26, 2023 05:45
sqin2019 pushed a commit that referenced this pull request Apr 6, 2023
This isn't a perfect solution because there's some error during JSON marshalling, but I don't think we should take the overhead of marshalling the JSON.

Fixes GH-170
verbanicm pushed a commit that referenced this pull request Jun 14, 2023
This isn't a perfect solution because there's some error during JSON marshalling, but I don't think we should take the overhead of marshalling the JSON.

Fixes GH-170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Token reason should have a size limit (or with truncate)
2 participants