Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix viewer resizing issue #559

Merged
merged 5 commits into from
Oct 14, 2022
Merged

Fix viewer resizing issue #559

merged 5 commits into from
Oct 14, 2022

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Oct 14, 2022

Description

Fixed issues introduced in #552:

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

@abey79 abey79 marked this pull request as ready for review October 14, 2022 07:59
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 94.73% // Head: 94.73% // No change to project coverage 👍

Coverage data is based on head (b3e76d0) compared to base (344d110).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #559   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files          62       62           
  Lines        5681     5681           
  Branches      767      767           
=======================================
  Hits         5382     5382           
  Misses        182      182           
  Partials      117      117           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@abey79 abey79 mentioned this pull request Oct 14, 2022
10 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abey79 abey79 merged commit df6c877 into master Oct 14, 2022
@abey79 abey79 deleted the fix-viewer-resize branch October 14, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant