Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PySide6 to 6.4.0 #562

Closed
wants to merge 2 commits into from
Closed

Update PySide6 to 6.4.0 #562

wants to merge 2 commits into from

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Oct 14, 2022 •
edited
Loading

Description

The old-style enums now break mypy (https://www.qt.io/blog/qt-for-python-release-6.4-is-finally-here), so code had to be updated.

This is postponed until:

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

@abey79 abey79 mentioned this pull request Oct 14, 2022
Merged
10 tasks
@codecov
Copy link

codecov bot commented Oct 14, 2022 •
edited
Loading

Codecov Report

Base: 94.73% // Head: 94.73% // No change to project coverage 👍

Coverage data is based on head (f310ed0) compared to base (df6c877).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #562   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files          62       62           
  Lines        5681     5681           
  Branches      767      767           
=======================================
  Hits         5382     5382           
  Misses        182      182           
  Partials      117      117

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

abey79 added 2 commits October 14, 2022 16:58
@abey79
Update to PySide 6.4.0
3a82099 
mypy complains due to the new enum, so the code must be converted to the new style an pyside6 pinned to min 6.4.0
@abey79
Dep lock
f310ed0
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abey79 abey79 mentioned this pull request Nov 12, 2022
Merged
10 tasks
@abey79 abey79 closed this Mar 10, 2023
@abey79
Copy link
Owner Author

abey79 commented Mar 10, 2023

Superseded by #581

@abey79 abey79 deleted the pyside-6.4 branch March 10, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abey79