Write kubeconfig to KUBECONFIG defined file #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sumoa can you kindly rebase? I fixed the broken CI. |
Sumoa
force-pushed
the
main
branch
4 times, most recently
from
aec4111
to
0c03784
Compare
Currently when starting a vm + k8s cluster the kubeconfig is always written to "~/.kube/config" which is the default path. By defining the env variable "KUBECONFIG" it is possible to override the default path. This does currently not apply to colima. As it is possible to configure multiple locations with "KUBECONFIG" I opted to always use the first configured one as the location to save the config.
abiosoft
reviewed
Apr 15, 2024
| @@ -42,6 +43,10 @@ func (c kubernetesRuntime) provisionKubeconfig(ctx context.Context) error { | |||
| }) | |||
|
|
|||
| kubeconfFile := filepath.Join(hostKubeDir, "config") | |||
| envKubeConfFile := c.host.Env("KUBECONFIG") | |||
| if envKubeConfFile != "" { | |||
| kubeconfFile = strings.Split(envKubeConfFile, string(os.PathListSeparator))[0] | |||
There was a problem hiding this comment.
Actually there is an in-built function for this filepath.SplitList https://pkg.go.dev/path/filepath@go1.22.2#SplitList.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when starting a vm + k8s cluster the kubeconfig is always written to "~/.kube/config" which is the default path. By defining the env variable "KUBECONFIG" it is possible to override the default path. This does currently not apply to colima.
As it is possible to configure multiple locations with "KUBECONFIG" I opted to always use the first configured one as the location to save the config.