Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write kubeconfig to KUBECONFIG defined file #978

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Write kubeconfig to KUBECONFIG defined file #978

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9806308
Write kubeconfig to KUBECONFIG defined file
Sumoa Apr 3, 2024
965a12a
Use os.PathListSeparator
Sumoa Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions environment/container/kubernetes/kubeconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package kubernetes
import (
"context"
"fmt"
"os"
"path/filepath"
"strings"
"time"
Expand Down Expand Up @@ -42,6 +43,10 @@ func (c kubernetesRuntime) provisionKubeconfig(ctx context.Context) error {
})

kubeconfFile := filepath.Join(hostKubeDir, "config")
envKubeConfFile := c.host.Env("KUBECONFIG")
if envKubeConfFile != "" {
kubeconfFile = strings.Split(envKubeConfFile, string(os.PathListSeparator))[0]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there is an in-built function for this filepath.SplitList https://pkg.go.dev/path/filepath@go1.22.2#SplitList.

}
tmpkubeconfFile := filepath.Join(hostKubeDir, "."+profile, "colima-temp")

// manipulate in VM and save to host
Expand Down
Loading