Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase emulation test coverage to include our minimum supported Android API Level #809

Closed
QuintinWillison opened this issue Jun 22, 2022 · 1 comment · Fixed by #812
Closed

Increase emulation test coverage to include our minimum supported Android API Level #809

QuintinWillison opened this issue Jun 22, 2022 · 1 comment · Fixed by #812
Assignees
@qsdigor

Comments

@QuintinWillison
Copy link
Contributor

QuintinWillison commented Jun 22, 2022 •
edited by sync-by-unito bot
Loading

Currently we only test API Level 24.

I think we now need a matrix, still including 24, but adding 19 (our new minimum) and the current latest level.

I would suggest branching off the branch underlying #807 to get this work started, which will allow it to support us in testing #808.

┆Issue is synchronized with this Jira Uncategorised by Unito
@qsdigor qsdigor linked a pull request Jun 30, 2022 that will close this issue
Add multiple android emulation devices #812
Merged
@qsdigor
Copy link
Contributor

qsdigor commented Jun 30, 2022 •
edited
Loading

Added exclusion for test for API 19 which does not support PATCH over HttpURLConnection. Other tests and devices pass successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qsdigor qsdigor

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add multiple android emulation devices ably/ably-java
2 participants
@QuintinWillison @qsdigor