Fix Java-WebSocket problem on Android below 24 #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KacperKluka
commented
Jun 21, 2022
lib/src/main/java/io/ably/lib/transport/WebSocketTransport.java
Outdated
Show resolved
Hide resolved
QuintinWillison
suggested changes
Jun 21, 2022
lib/src/main/java/io/ably/lib/transport/WebSocketTransport.java
Outdated
Show resolved
Hide resolved
lib/src/main/java/io/ably/lib/transport/WebSocketTransport.java
Outdated
Show resolved
Hide resolved
qsdigor
approved these changes
Jun 22, 2022
QuintinWillison
approved these changes
Jun 22, 2022
|
Even though the CI integration-test is failing we are going to land this PR because of those reasons 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a known issue in the Java-WebSocket library that has affected us after the recent upgrade. Luckily, there's a workaround that we have added to make it work.