Increase minimum JRE version to 1.8 #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equired by Android.
QuintinWillison
requested review from
AndyNicks,
ikbalkaya,
KacperKluka and
qsdigor
AndyNicks
approved these changes
Jun 20, 2022
KacperKluka
approved these changes
Jun 21, 2022
qsdigor
approved these changes
Jun 21, 2022
ikbalkaya
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow we were building for Android at 1.8 already anyway.
Common to my statement on #804, I propose releasing this with our next version
1.2patch and, as such, am treating this change as foundational to my fix for #801.I will be very surprised if we have any customers still building against JDK 1.7 and/or targeting JRE 1.7 specifically. If there are any, this will break at build time for them so does not represent a runtime risk, so I am happy to take on the support burden of assisting those customers if this becomes an issue for them.
FYI, @paddybyers @stmoreau