fix: create Cipher instance in place, do not store it in ChannelOptions
#969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/969/features
github-actions
bot
temporarily deployed
to
staging/pull/969/javadoc
…ons` Cipher instances was cached per `ChannelOptions` that probably increased performance a little, but it was causing `ConcurrentModificationException`. Now we create cipher instance during encryption/decryption process to avoid this
ttypic
force-pushed
the
fix-ably-concurrent-encryption
branch
from
8858c56 to
da5406f
Compare
github-actions
bot
temporarily deployed
to
staging/pull/969/features
github-actions
bot
temporarily deployed
to
staging/pull/969/javadoc
github-actions
bot
temporarily deployed
to
staging/pull/969/features
github-actions
bot
temporarily deployed
to
staging/pull/969/javadoc
github-actions
bot
temporarily deployed
to
staging/pull/969/features
github-actions
bot
temporarily deployed
to
staging/pull/969/javadoc
ttypic
force-pushed
the
fix-ably-concurrent-encryption
branch
from
d4a9c09 to
aad3380
Compare
github-actions
bot
temporarily deployed
to
staging/pull/969/features
github-actions
bot
temporarily deployed
to
staging/pull/969/javadoc
AndyTWF
approved these changes
Sep 28, 2023
ttypic
force-pushed
the
fix-ably-concurrent-encryption
branch
from
aad3380 to
8e84a14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: Cipher instances was cached per
ChannelOptionsthat probably increased performance a little bit, but it was causingConcurrentModificationException.Now: we create cipher instance during encryption/decryption process to avoid this.
see ably/ably-flutter#483